[Mac] Refactor the fullscreen toolbar mouse tracker

[Mac] Refactor the fullscreen toolbar mouse tracker

- Moved the mouse tracker logic from FullscreenToolbarController into a new
class

BUG=643418
Committed: https://crrev.com/363cae95747a3f1e34f5e2fc6ad4d95eb9af40b7
Cr-Commit-Position: refs/heads/master@{#428086}

[spqchan, 2016-10-26 01:30:00]

spqchan@chromium.org changed reviewers:
+ erikchen@chromium.org

[spqchan, 2016-10-26 01:30:01]

PTAL

[erikchen, 2016-10-26 17:26:10]

https://codereview.chromium.org/2446313005/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm
(right):

https://codereview.chromium.org/2446313005/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm:52:
contentView_ = [[bwc window] contentView];
When we add the tracking area, we should dynamically compute contentView_, and
then unset it when we remove the tracking area.

[spqchan, 2016-10-26 17:42:50]

PTAL

https://codereview.chromium.org/2446313005/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm
(right):

https://codereview.chromium.org/2446313005/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm:52:
contentView_ = [[bwc window] contentView];
On 2016/10/26 17:26:10, erikchen wrote:
> When we add the tracking area, we should dynamically compute contentView_, and
> then unset it when we remove the tracking area.

Done.

[erikchen, 2016-10-26 17:45:18]

lgtm

[spqchan, 2016-10-26 18:53:27]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-10-26 18:53:28]

thanks!

+rsesek for ownership

[Robert Sesek, 2016-10-27 16:22:06]

LGTM

https://codereview.chromium.org/2446313005/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.h
(right):

https://codereview.chromium.org/2446313005/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.h:10: @class
BrowserWindowController;
Can remove this and the next line since they're not used in the header.

[spqchan, 2016-10-27 17:12:23]

Thanks!

https://codereview.chromium.org/2446313005/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.h
(right):

https://codereview.chromium.org/2446313005/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.h:10: @class
BrowserWindowController;
On 2016/10/27 16:22:06, Robert Sesek wrote:
> Can remove this and the next line since they're not used in the header.

Done.

[spqchan, 2016-10-27 17:12:28]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-10-27 17:12:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2446313005/#ps60001
(title: "Fix for rsesek")

[commit-bot: I haz the power, 2016-10-27 17:12:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 18:29:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-27 19:01:28]

Description was changed from

==========
[Mac] Refactor the fullscreen toolbar mouse tracker

- Moved the mouse tracker logic from FullscreenToolbarController into a new
class

BUG=643418
==========

to

==========
[Mac] Refactor the fullscreen toolbar mouse tracker

- Moved the mouse tracker logic from FullscreenToolbarController into a new
class

BUG=643418

Committed: https://crrev.com/363cae95747a3f1e34f5e2fc6ad4d95eb9af40b7
Cr-Commit-Position: refs/heads/master@{#428086}
==========

[commit-bot: I haz the power, 2016-10-27 19:01:30]

Patchset 4 (id:??) landed as
https://crrev.com/363cae95747a3f1e34f5e2fc6ad4d95eb9af40b7
Cr-Commit-Position: refs/heads/master@{#428086}