Issue 2446313002: white spaces and comments for msa

lint failures: include/libyuv/macros_msa.h:19: Extra space after ( [whitespace/parens] [2] include/libyuv/macros_msa.h:20: Using C-style cast. Use reinterpret_cast<uint8 ...

4 years, 1 month ago (2016-10-25 18:17:49 UTC) #2

lint failures:
include/libyuv/macros_msa.h:19:  Extra space after (  [whitespace/parens] [2]
include/libyuv/macros_msa.h:20:  Using C-style cast.  Use reinterpret_cast<uint8
*>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:20:  Declaration has space between type name and *
in uint8 *psrc_lw_m  [whitespace/declaration] [3]
include/libyuv/macros_msa.h:32:  Extra space after (  [whitespace/parens] [2]
include/libyuv/macros_msa.h:33:  Using C-style cast.  Use reinterpret_cast<uint8
*>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:33:  Declaration has space between type name and *
in uint8 *psrc_ld_m  [whitespace/declaration] [3]
include/libyuv/macros_msa.h:43:  Extra space after (  [whitespace/parens] [2]
include/libyuv/macros_msa.h:44:  Using C-style cast.  Use reinterpret_cast<uint8
*>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:44:  Declaration has space between type name and *
in uint8 *psrc_ld_m  [whitespace/declaration] [3]
include/libyuv/macros_msa.h:49:  Using C-style cast.  Use
static_cast<uint64>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:50:  Using C-style cast.  Use
static_cast<uint64>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:51:  Using C-style cast.  Use
static_cast<uint64>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:56:  Extra space after (  [whitespace/parens] [2]
include/libyuv/macros_msa.h:57:  Using C-style cast.  Use reinterpret_cast<uint8
*>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:57:  Declaration has space between type name and *
in uint8 *psrc_lw_m  [whitespace/declaration] [3]
include/libyuv/macros_msa.h:68:  Extra space after (  [whitespace/parens] [2]
include/libyuv/macros_msa.h:69:  Using C-style cast.  Use reinterpret_cast<uint8
*>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:69:  Declaration has space between type name and *
in uint8 *psrc_ld_m  [whitespace/declaration] [3]
include/libyuv/macros_msa.h:79:  Extra space after (  [whitespace/parens] [2]
include/libyuv/macros_msa.h:80:  Using C-style cast.  Use reinterpret_cast<uint8
*>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:80:  Declaration has space between type name and *
in uint8 *psrc_ld_m  [whitespace/declaration] [3]
include/libyuv/macros_msa.h:85:  Using C-style cast.  Use
static_cast<uint64>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:86:  Using C-style cast.  Use
static_cast<uint64>(...) instead  [readability/casting] [4]
include/libyuv/macros_msa.h:87:  Using C-style cast.  Use
static_cast<uint64>(...) instead  [readability/casting] [4]
Done processing include/libyuv/macros_msa.h
include/libyuv/row.h:177:  Should have a space between // and comment 
[whitespace/comments] [4]
include/libyuv/row.h:180:  Should have a space between // and comment 
[whitespace/comments] [4]
include/libyuv/row.h:183:  Should have a space between // and comment 
[whitespace/comments] [4]
Done processing include/libyuv/row.h
source/row_msa.cc:380:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:381:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:382:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:383:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:431:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:432:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:433:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:434:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:435:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:436:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:437:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:438:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:459:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:460:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:461:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:462:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:463:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:464:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:465:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:466:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:538:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:539:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
Done processing source/row_msa.cc
Total errors found: 49

fbarchard1

fixed some of the lint warnings, disabled some. lint now: git cl lint Done processing ...

4 years, 1 month ago (2016-10-25 18:35:19 UTC) #3

fixed some of the lint warnings, disabled some.  lint now:

git cl lint
Done processing include/libyuv/macros_msa.h
source/row_msa.cc:380:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:381:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:382:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:383:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:431:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:432:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:433:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:434:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:435:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:436:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:437:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:438:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:459:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:460:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:461:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:462:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:463:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:464:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:465:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:466:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:538:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
source/row_msa.cc:539:  Using C-style cast.  Use reinterpret_cast<v16u8*>(...)
instead  [readability/casting] [4]
Done processing source/row_msa.cc
Total errors found: 22

fbarchard1

Committed patchset #4 (id:60001) manually as 2488b3105b68be8ea33f88722537427e361cbed2 (presubmit successful).

4 years, 1 month ago (2016-10-25 18:36:56 UTC) #6

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages