Ignore expired mobile provisioning profiles.

Ignore expired mobile provisioning profiles.

Ignore mobile provisioning profile that are expired (or soon going to
expire, i.e. expiration date arrives in less than 1 hour) and warn
about the soon-to-expire mobile provisioning profile.

If two mobile provisioning profile can be used to sign a bundle, use
the one that will expire the latest.

Pass the -u parameter to prevent "security" displaying an error
message when compiling on macOS Sierra.

BUG=659142, 657521
Committed: https://crrev.com/b7c2e30b74d87e45f1aa508c028d9927829b8fd0
Cr-Commit-Position: refs/heads/master@{#427408}

[sdefresne, 2016-10-25 16:39:48]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-10-25 16:40:02]

sdefresne@chromium.org changed reviewers:
+ justincohen@chromium.org

[sdefresne, 2016-10-25 16:40:03]

Please take a look and send to CQ if lgty.

[sdefresne, 2016-10-25 16:40:06]

The CQ bit was unchecked by sdefresne@chromium.org

[justincohen, 2016-10-25 17:41:51]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-10-25 17:41:51]

lgtm

Awesome, LGTM with one unrelated question.

https://codereview.chromium.org/2446283002/diff/1/build/config/ios/codesign.py
File build/config/ios/codesign.py (right):

https://codereview.chromium.org/2446283002/diff/1/build/config/ios/codesign.p...
build/config/ios/codesign.py:104: self.application_identifier_pattern)
can application identifier pattern include a star, etc com.chromium.*?  Will
this support that?

https://codereview.chromium.org/2446283002/diff/1/build/config/ios/codesign.p...
build/config/ios/codesign.py:198: 'Warning: selected provisioning profile will
expire soon: %s' %
awesome!

[commit-bot: I haz the power, 2016-10-25 17:42:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-10-25 17:54:57]

Thank you for the review.

https://codereview.chromium.org/2446283002/diff/1/build/config/ios/codesign.py
File build/config/ios/codesign.py (right):

https://codereview.chromium.org/2446283002/diff/1/build/config/ios/codesign.p...
build/config/ios/codesign.py:104: self.application_identifier_pattern)
On 2016/10/25 17:41:51, justincohen wrote:
> can application identifier pattern include a star, etc com.chromium.*?  Will
> this support that?

Yes and yes (this is why I'm using fnmatch.fnmatch which implements shell
pattern matching rules for * which are exactly what is needed here).

https://codereview.chromium.org/2446283002/diff/1/build/config/ios/codesign.p...
build/config/ios/codesign.py:198: 'Warning: selected provisioning profile will
expire soon: %s' %
On 2016/10/25 17:41:51, justincohen wrote:
> awesome!

Acknowledged.

[commit-bot: I haz the power, 2016-10-25 17:57:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-25 18:03:32]

Description was changed from

==========
Ignore expired mobile provisioning profiles.

Ignore mobile provisioning profile that are expired (or soon going to
expire, i.e. expiration date arrives in less than 1 hour) and warn
about the soon-to-expire mobile provisioning profile.

If two mobile provisioning profile can be used to sign a bundle, use
the one that will expire the latest.

Pass the -u parameter to prevent "security" displaying an error
message when compiling on macOS Sierra.

BUG=659142,657521
==========

to

==========
Ignore expired mobile provisioning profiles.

Ignore mobile provisioning profile that are expired (or soon going to
expire, i.e. expiration date arrives in less than 1 hour) and warn
about the soon-to-expire mobile provisioning profile.

If two mobile provisioning profile can be used to sign a bundle, use
the one that will expire the latest.

Pass the -u parameter to prevent "security" displaying an error
message when compiling on macOS Sierra.

BUG=659142,657521

Committed: https://crrev.com/b7c2e30b74d87e45f1aa508c028d9927829b8fd0
Cr-Commit-Position: refs/heads/master@{#427408}
==========

[commit-bot: I haz the power, 2016-10-25 18:03:33]

Patchset 1 (id:??) landed as
https://crrev.com/b7c2e30b74d87e45f1aa508c028d9927829b8fd0
Cr-Commit-Position: refs/heads/master@{#427408}