Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2446273006: Simplify return expression in ConfiguratorImpl::StepDelay() (Closed)

Created:
4 years, 1 month ago by hans
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify return expression in ConfiguratorImpl::StepDelay() Found by PVS-Studio! BUG=660198 Committed: https://crrev.com/54a5efa8bb07fd1fe99ad9cf3505c584611b0f6c Cr-Commit-Position: refs/heads/master@{#429032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/component_updater/configurator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
hans
Please take a look.
4 years, 1 month ago (2016-10-27 22:31:34 UTC) #2
droger
lgtm
4 years, 1 month ago (2016-10-28 09:05:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446273006/1
4 years, 1 month ago (2016-10-28 16:00:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/292063)
4 years, 1 month ago (2016-10-28 16:08:52 UTC) #7
hans
oops, I was too fast :-) cpu: Still need your owner stamp.
4 years, 1 month ago (2016-10-28 16:10:35 UTC) #8
hans
+waffles: maybe you can provide OWNERS stamp?
4 years, 1 month ago (2016-11-01 16:30:56 UTC) #10
waffles
lgtm
4 years, 1 month ago (2016-11-01 16:34:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446273006/1
4 years, 1 month ago (2016-11-01 16:41:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 17:24:30 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 17:53:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54a5efa8bb07fd1fe99ad9cf3505c584611b0f6c
Cr-Commit-Position: refs/heads/master@{#429032}

Powered by Google App Engine
This is Rietveld 408576698