Fix bad focus state tracking

Fix bad focus state tracking

Since |automationUtil.updateFocusedNode| gets called both from the client |getFocus| api as well as by onAccessibilityEvents (when receiving focus events), we sometimes discarded focus events because we updated focus when a client called getFocus before the actual focus event fires.

In the attached bug, we fire a childrenChanged event where we already implicitly changed the focused node. On an event handler, a client calls getFocus, updating the focused node. The next event, the actual focus event, is discard incorrectly.

BUG=658621
Committed: https://crrev.com/6e3a3a84756c2ee9d06f9c0766b694ea6520f368
Cr-Commit-Position: refs/heads/master@{#427417}

[David Tseng, 2016-10-25 15:44:18]

Description was changed from

==========
Fix bad focus state tracking

Since |automationUtil.updateFocusedNode| gets called both from the client
|getFocus| api as well as by onAccessibilityEvents (when receiving focus
events), we sometimes discarded focus events because we updated focus when a
client called getFocus before the actual focus event fires.

In the attached bug, we fire a childrenChanged event where we already implicitly
changed the focused node. On an event handler, a client calls getFocus, updating
the focused node. The next event, the actual focus event, is discard
incorrectly.

BUG=
==========

to

==========
Fix bad focus state tracking

Since |automationUtil.updateFocusedNode| gets called both from the client
|getFocus| api as well as by onAccessibilityEvents (when receiving focus
events), we sometimes discarded focus events because we updated focus when a
client called getFocus before the actual focus event fires.

In the attached bug, we fire a childrenChanged event where we already implicitly
changed the focused node. On an event handler, a client calls getFocus, updating
the focused node. The next event, the actual focus event, is discard
incorrectly.

BUG=658621
==========

[David Tseng, 2016-10-25 15:44:18]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-10-25 16:57:26]

lgtm

Good catch

[David Tseng, 2016-10-25 17:32:51]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:33:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:22:12]

Description was changed from

==========
Fix bad focus state tracking

Since |automationUtil.updateFocusedNode| gets called both from the client
|getFocus| api as well as by onAccessibilityEvents (when receiving focus
events), we sometimes discarded focus events because we updated focus when a
client called getFocus before the actual focus event fires.

In the attached bug, we fire a childrenChanged event where we already implicitly
changed the focused node. On an event handler, a client calls getFocus, updating
the focused node. The next event, the actual focus event, is discard
incorrectly.

BUG=658621
==========

to

==========
Fix bad focus state tracking

Since |automationUtil.updateFocusedNode| gets called both from the client
|getFocus| api as well as by onAccessibilityEvents (when receiving focus
events), we sometimes discarded focus events because we updated focus when a
client called getFocus before the actual focus event fires.

In the attached bug, we fire a childrenChanged event where we already implicitly
changed the focused node. On an event handler, a client calls getFocus, updating
the focused node. The next event, the actual focus event, is discard
incorrectly.

BUG=658621
==========

[commit-bot: I haz the power, 2016-10-25 18:22:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-25 18:38:27]

Description was changed from

==========
Fix bad focus state tracking

Since |automationUtil.updateFocusedNode| gets called both from the client
|getFocus| api as well as by onAccessibilityEvents (when receiving focus
events), we sometimes discarded focus events because we updated focus when a
client called getFocus before the actual focus event fires.

In the attached bug, we fire a childrenChanged event where we already implicitly
changed the focused node. On an event handler, a client calls getFocus, updating
the focused node. The next event, the actual focus event, is discard
incorrectly.

BUG=658621
==========

to

==========
Fix bad focus state tracking

Since |automationUtil.updateFocusedNode| gets called both from the client
|getFocus| api as well as by onAccessibilityEvents (when receiving focus
events), we sometimes discarded focus events because we updated focus when a
client called getFocus before the actual focus event fires.

In the attached bug, we fire a childrenChanged event where we already implicitly
changed the focused node. On an event handler, a client calls getFocus, updating
the focused node. The next event, the actual focus event, is discard
incorrectly.

BUG=658621

Committed: https://crrev.com/6e3a3a84756c2ee9d06f9c0766b694ea6520f368
Cr-Commit-Position: refs/heads/master@{#427417}
==========

[commit-bot: I haz the power, 2016-10-25 18:38:29]

Patchset 1 (id:??) landed as
https://crrev.com/6e3a3a84756c2ee9d06f9c0766b694ea6520f368
Cr-Commit-Position: refs/heads/master@{#427417}