[builtins] Fix Object.create(null) special case

[builtins] Fix Object.create(null) special case

Fix failing assertions in the CodeStubAssembler that cause Object.create(null,
global) fail.
Drive-by-fix: convert some Assert to CSA_ASSERT.

BUG=chromium:657692
Committed: https://crrev.com/58e0e3f635d028ed7dfcb123062db7f412c9407f
Cr-Commit-Position: refs/heads/master@{#40576}

[Camillo Bruni, 2016-10-25 16:04:39]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 16:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 16:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 16:33:39]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-10-25 18:28:45]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2016-10-25 18:28:45]

PTAL

[Jakob Kummerow, 2016-10-25 19:51:37]

LGTM with nits

https://codereview.chromium.org/2446203003/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2446203003/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:8420: // CSA_ASSERT: Type(array) is Object
nit: I'd undo this edit. Comments are for humans, "Assert" is more readable.

https://codereview.chromium.org/2446203003/diff/1/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2446203003/diff/1/src/code-stub-assembler.h#n...
src/code-stub-assembler.h:713: // Returns true if any of the |T|'s bits in given
|word32| are set.
nit: s/|T|/mask/

[Camillo Bruni, 2016-10-26 06:55:51]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-10-26 06:55:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2446203003/#ps20001
(title: "addressing nits")

[commit-bot: I haz the power, 2016-10-26 06:56:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 07:21:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:13:12]

Description was changed from

==========
[builtins] Fix Object.create(null) special case

Fix failing assertions in the CodeStubAssembler that cause Object.create(null,
global) fail.
Drive-by-fix: convert some Assert to CSA_ASSERT.

BUG=chromium:657692
==========

to

==========
[builtins] Fix Object.create(null) special case

Fix failing assertions in the CodeStubAssembler that cause Object.create(null,
global) fail.
Drive-by-fix: convert some Assert to CSA_ASSERT.

BUG=chromium:657692

Committed: https://crrev.com/58e0e3f635d028ed7dfcb123062db7f412c9407f
Cr-Commit-Position: refs/heads/master@{#40576}
==========

[commit-bot: I haz the power, 2016-11-17 22:13:13]

Patchset 2 (id:??) landed as
https://crrev.com/58e0e3f635d028ed7dfcb123062db7f412c9407f
Cr-Commit-Position: refs/heads/master@{#40576}