Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2446173002: Use RTCPeerConnection instead of webkitRTCPeerConnection (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+mediastream_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, tommyw+watchlist_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use RTCPeerConnection instead of webkitRTCPeerConnection Cases where the second argument (constraints) is used are left alone, as a reminder that this isn't standarized behavior. BUG=658423 Committed: https://crrev.com/04209ec5b08095a9b207905c6d6090478892345a Cr-Commit-Position: refs/heads/master@{#427662}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -173 lines) Patch
M chrome/common/extensions/docs/examples/api/desktopCapture/app.js View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/end_to_end.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/performance.js View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/media/datachannel_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/media/mediarecorder_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/examples/video_effects/video_effects.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/constructors.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/constructors-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html View 4 chunks +56 lines, -54 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-AddRemoveStream.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createAnswer.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createAnswer-promise.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer-promise.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-dtmf.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-events.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt View 1 1 chunk +52 lines, -51 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-generateCertificate.html View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice-promise.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice-promise-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription-promise.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-onnegotiationneeded.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription-promise.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-state.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsSelector.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsSelector-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
foolip
PTAL. This depends on earlier CLs and will probably need to be rebased before landing, ...
4 years, 1 month ago (2016-10-25 13:26:25 UTC) #2
bbudge
ppapi lgtm
4 years, 1 month ago (2016-10-25 13:36:37 UTC) #3
hta - Chromium
lgtm
4 years, 1 month ago (2016-10-25 14:28:00 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-10-25 16:01:41 UTC) #5
miu
chrome/test/data/extensions/api_test/tab_capture/* lgtm
4 years, 1 month ago (2016-10-26 03:17:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446173002/20001
4 years, 1 month ago (2016-10-26 10:38:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 10:42:27 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 10:44:57 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04209ec5b08095a9b207905c6d6090478892345a
Cr-Commit-Position: refs/heads/master@{#427662}

Powered by Google App Engine
This is Rietveld 408576698