Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2446113013: s390x: Fix the logic to detect INT_MIN in simulator (Closed)

Created:
4 years, 1 month ago by JaideepBajwa
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390x: Fix the logic to detect INT_MIN in simulator Converting INT_MIN to positive should cause overflow, which was not being captured. Fixed the logic to detect if value is equal to INT_MIN and set the overflow code accordingly. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/4d6df11f2c8ed0968c0a34a480c5f4a3e1dc3cca Cr-Commit-Position: refs/heads/master@{#40631}

Patch Set 1 #

Patch Set 2 : minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/s390/simulator-s390.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 1 month ago (2016-10-27 21:23:57 UTC) #1
john.yan
lgtm
4 years, 1 month ago (2016-10-27 21:30:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446113013/20001
4 years, 1 month ago (2016-10-27 21:31:18 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 22:05:23 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d6df11f2c8ed0968c0a34a480c5f4a3e1dc3cca
Cr-Commit-Position: refs/heads/master@{#40631}

Powered by Google App Engine
This is Rietveld 408576698