Chromium Code Reviews
DescriptionRevert of Showing previews UI for Offline Previews (patchset #15 id:280001 of https://codereview.chromium.org/2362033002/ )
Reason for revert:
The following tests are failing on Android Tests:
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnConnectionTypeChanged_pageNotLoaded
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnDestroyed
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnPageLoadFinished_notConnected
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnPageLoadFinished
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testShowSnackbar_ignoreEventsAfterShownOnce
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testAddObserverForTab
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnUrlUpdated_whenSnackbarShown
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnHidden_afterSnackbarShown
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnConnectionTypeChanged_notConnected
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testShowSnackbar_onConnectionTypeChanged
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testAddObserverForTab_whenConnected
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testShowSnackbar_onShown
org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testShowSnackbar_onPageLoadFinished
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/33841
Original issue's description:
> Showing previews UI for Offline Previews
>
> This changes the functionality of is_offline_preview() in OfflinePageTabHelper to check the provisional information as well.
>
> Additionally, this CL addresses other consumers of this information that
> want access to it in DidFinishNavigation. Specifically,
> PreviewsPageLoadMetricsObserver will access the is_offline_previews bit
> as will PreviewsInfoBarHelper.
>
> This also prevents showing the offline pages snackbar and replaces it with
> the previews infobar. This leaves the Offline omnibox and other UI
> features.
>
> BUG=615564, 649148
>
> Committed: https://crrev.com/21364834a65e541369e8895d93695dfaf114056b
> Cr-Commit-Position: refs/heads/master@{#427902}
TBR=bmcquade@chromium.org,jianli@chromium.org,megjablon@chromium.org,ryansturm@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615564, 649148
Committed: https://crrev.com/7d6eaf7adcb3f61835051ae104fee8f61f2144ca
Cr-Commit-Position: refs/heads/master@{#427938}
Patch Set 1 #Messages
Total messages: 7 (2 generated)
|