Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2446113008: Revert of Showing previews UI for Offline Previews (Closed)

Created:
4 years, 1 month ago by alancutter (OOO until 2018)
Modified:
4 years, 1 month ago
CC:
chili+watch_chromium.org, chromium-reviews, dewittj+watch_chromium.org, dimich+watch_chromium.org, fgorski+watch_chromium.org, petewil+watch_chromium.org, romax+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Showing previews UI for Offline Previews (patchset #15 id:280001 of https://codereview.chromium.org/2362033002/ ) Reason for revert: The following tests are failing on Android Tests: org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnConnectionTypeChanged_pageNotLoaded org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnDestroyed org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnPageLoadFinished_notConnected org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnPageLoadFinished org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testShowSnackbar_ignoreEventsAfterShownOnce org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testAddObserverForTab org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnUrlUpdated_whenSnackbarShown org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnHidden_afterSnackbarShown org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testOnConnectionTypeChanged_notConnected org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testShowSnackbar_onConnectionTypeChanged org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testAddObserverForTab_whenConnected org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testShowSnackbar_onShown org.chromium.chrome.browser.offlinepages.OfflinePageTabObserverTest#testShowSnackbar_onPageLoadFinished https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/33841 Original issue's description: > Showing previews UI for Offline Previews > > This changes the functionality of is_offline_preview() in OfflinePageTabHelper to check the provisional information as well. > > Additionally, this CL addresses other consumers of this information that > want access to it in DidFinishNavigation. Specifically, > PreviewsPageLoadMetricsObserver will access the is_offline_previews bit > as will PreviewsInfoBarHelper. > > This also prevents showing the offline pages snackbar and replaces it with > the previews infobar. This leaves the Offline omnibox and other UI > features. > > BUG=615564, 649148 > > Committed: https://crrev.com/21364834a65e541369e8895d93695dfaf114056b > Cr-Commit-Position: refs/heads/master@{#427902} TBR=bmcquade@chromium.org,jianli@chromium.org,megjablon@chromium.org,ryansturm@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615564, 649148 Committed: https://crrev.com/7d6eaf7adcb3f61835051ae104fee8f61f2144ca Cr-Commit-Position: refs/heads/master@{#427938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -150 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/previews/previews_infobar_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper.h View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper.cc View 3 chunks +14 lines, -32 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper_unittest.cc View 4 chunks +0 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alancutter (OOO until 2018)
Created Revert of Showing previews UI for Offline Previews
4 years, 1 month ago (2016-10-27 04:23:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446113008/1
4 years, 1 month ago (2016-10-27 04:24:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 04:25:43 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7d6eaf7adcb3f61835051ae104fee8f61f2144ca Cr-Commit-Position: refs/heads/master@{#427938}
4 years, 1 month ago (2016-10-27 04:27:49 UTC) #6
RyanSturm
4 years, 1 month ago (2016-10-27 13:39:57 UTC) #7
Message was sent while issue was closed.
LGTM, I'll reland once I fix the problem.

Powered by Google App Engine
This is Rietveld 408576698