DevTools: add tests for device mode's responsive mode

third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @param {!WebInspector.DeviceModeModel} model
  * @param {!WebInspector.Setting} showMediaInspectorSetting
  * @param {!WebInspector.Setting} showRulersSetting
  * @constructor
  */
@@ skipping 65 matching lines @@
 
     /**
      * @param {!WebInspector.Toolbar} toolbar
      */
     _fillMainToolbar: function(toolbar)
     {
         var widthInput = createElementWithClass("input", "device-mode-size-input");
         widthInput.maxLength = 4;
         widthInput.type = "text";
         widthInput.title = WebInspector.UIString("Width");
-        this._updateWidthInput = WebInspector.bindInput(widthInput, applyWidth.bind(this), WebInspector.DeviceModeModel.deviceSizeValidator, true);
+        this._updateWidthInput = WebInspector.bindInput(widthInput, this._applyWidth.bind(this), WebInspector.DeviceModeModel.deviceSizeValidator, true);
         this._widthInput = widthInput;
         this._widthItem = this._wrapToolbarItem(widthInput);
         toolbar.appendToolbarItem(this._widthItem);
 
         var xElement = createElementWithClass("div", "device-mode-x");
         xElement.textContent = "\u00D7";
         this._xItem = this._wrapToolbarItem(xElement);
         toolbar.appendToolbarItem(this._xItem);
 
         var heightInput = createElementWithClass("input", "device-mode-size-input");
         heightInput.maxLength = 4;
         heightInput.type = "text";
         heightInput.title = WebInspector.UIString("Height (leave empty for full)");
-        this._updateHeightInput = WebInspector.bindInput(heightInput, applyHeight.bind(this), validateHeight, true);
+        this._updateHeightInput = WebInspector.bindInput(heightInput, this._applyHeight.bind(this), validateHeight, true);
         this._heightInput = heightInput;
         this._heightItem = this._wrapToolbarItem(heightInput);
         toolbar.appendToolbarItem(this._heightItem);
 
         /**
          * @param {string} value
          * @return {boolean}
          */
         function validateHeight(value)
         {
             return !value || WebInspector.DeviceModeModel.deviceSizeValidator(value);
         }
-
-        /**
-         * @param {string} value
-         * @this {WebInspector.DeviceModeToolbar}
-         */
-        function applyWidth(value)
-        {
-            var width = value ? Number(value) : 0;
-            this._model.setWidthAndScaleToFit(width);
-        }
-
-        /**
-         * @param {string} value
-         * @this {WebInspector.DeviceModeToolbar}
-         */
-        function applyHeight(value)
-        {
-            var height = value ? Number(value) : 0;
-            this._model.setHeightAndScaleToFit(height);
-        }
     },
 
     /**
+     * @param {string} value
+     * @this {WebInspector.DeviceModeToolbar}

[dgozman, 2016/10/26 18:35:22]

Don't need @this annotations on prototype functions.

[luoe, 2016/10/26 18:56:51]

Done.

+     */
+    _applyWidth: function(value)
+    {
+        var width = value ? Number(value) : 0;
+        this._model.setWidthAndScaleToFit(width);
+    },
+
+    /**
+     * @param {string} value
+     * @this {WebInspector.DeviceModeToolbar}
+     */
+    _applyHeight: function(value)
+    {
+        var height = value ? Number(value) : 0;
+        this._model.setHeightAndScaleToFit(height);
+    },
+
+    /**
      * @param {!WebInspector.Toolbar} toolbar
      */
     _fillRightToolbar: function(toolbar)
     {
         toolbar.appendToolbarItem(this._wrapToolbarItem(createElementWithClass("div", "device-mode-empty-toolbar-element")));
         this._scaleItem = new WebInspector.ToolbarMenuButton(this._appendScaleMenuItems.bind(this));
         this._scaleItem.setTitle(WebInspector.UIString("Zoom"));
         this._scaleItem.setGlyph("");
         this._scaleItem.turnIntoSelect();
         toolbar.appendToolbarItem(this._scaleItem);
@@ skipping 434 matching lines @@
                         this._emulateDevice(device);
                         return;
                     }
                 }
             }
         }
 
         this._model.emulate(WebInspector.DeviceModeModel.Type.Responsive, null, null);
     }
 };