Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2446103002: gl_context_glx: Do not use core profile on Mesa Optimus (Closed)

Created:
4 years, 1 month ago by Corentin Wallez
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl_context_glx: Do not use core profile on Mesa Optimus This patch hardcodes the workaround detection as it is needed at OpenGL context creation time. BUG=659030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ui/gl/gl_context_glx.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Zhenyao Mo
I prefer to go down the path of adding a gpu driver bug workaround (disable_gl_core_profile) ...
4 years, 1 month ago (2016-10-28 21:37:19 UTC) #2
Corentin Wallez
4 years, 1 month ago (2016-10-29 01:57:02 UTC) #3
On 2016/10/28 at 21:37:19, zmo wrote:
> I prefer to go down the path of adding a gpu driver bug workaround
(disable_gl_core_profile) and add an entry for mesa with optimus. That way we
can apply it to other problematic platforms and easy to disable (in the future
when the issue is fixed)

The problem is that we need to create a GL context to know it is Mesa, which we
need to have the workaround, which we need to create a GL context.

Powered by Google App Engine
This is Rietveld 408576698