chrome/browser/payments/BUILD.gn - Issue 2446093004: [Web Payments] Initial plumb of Payment Request dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/payments/BUILD.gn

Issue 2446093004: [Web Payments] Initial plumb of Payment Request dialog (Closed)

Patch Set: Remove mystery strings Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/payments/payment_request_impl.h » ('j') | chrome/browser/payments/payment_request_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 static_library("payments") {

	6 sources = [

	7 "payment_request_impl.cc",
	Lei Zhang 2016/11/09 18:08:55 Add the .h files too. Add the .h files too. Kevin Bailey 2016/11/15 14:36:32 Done. Show quoted text On 2016/11/09 18:08:55, Lei Zhang (slow) wrote: > Add the .h files too. Done.
	8 "ui/payment_request_dialog.cc",

	9 ]

	10 deps = [

	11 "//skia",
	Lei Zhang 2016/11/09 18:08:55 I don't see any Skia usage. Probably needs to depe I don't see any Skia usage. Probably needs to depend on components/payments at least. Kevin Bailey 2016/11/15 14:36:32 It whines about SkTypes.h. I added payments. Show quoted text On 2016/11/09 18:08:55, Lei Zhang (slow) wrote: > I don't see any Skia usage. Probably needs to depend on components/payments at > least. It whines about SkTypes.h. I added payments. Lei Zhang 2016/11/15 19:20:47 You probably want to depend on //ui/views? Show quoted text On 2016/11/15 14:36:32, Kevin Bailey wrote: > On 2016/11/09 18:08:55, Lei Zhang (slow) wrote: > > I don't see any Skia usage. Probably needs to depend on components/payments at > > least. > > It whines about SkTypes.h. I added payments. You probably want to depend on //ui/views? Kevin Bailey 2016/11/15 20:33:55 If one dependency is as good as another (per our d Show quoted text On 2016/11/15 19:20:47, Lei Zhang (not reviewing code) wrote: > On 2016/11/15 14:36:32, Kevin Bailey wrote: > > On 2016/11/09 18:08:55, Lei Zhang (slow) wrote: > > > I don't see any Skia usage. Probably needs to depend on components/payments > at > > > least. > > > > It whines about SkTypes.h. I added payments. > > You probably want to depend on //ui/views? If one dependency is as good as another (per our discussion). :)
	12 ]

	13 }

OLD	NEW