[Web Payments] Initial plumb of Payment Request dialog

chrome/browser/payments/payment_request_impl.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/payments/payment_request_impl.h"
+
+#include <map>
+
+#include "base/lazy_instance.h"
+#include "chrome/browser/payments/ui/payment_request_dialog.h"
+#include "components/web_modal/web_contents_modal_dialog_host.h"
+#include "components/web_modal/web_contents_modal_dialog_manager.h"
+#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/web_contents.h"
+
+namespace {
+
+class PaymentRequestFactory {
+ public:
+  bool AssignPaymentRequest(
+      content::WebContents* web_contents,
+      mojo::InterfaceRequest<payments::mojom::PaymentRequest> request) {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+    if (map_.find(web_contents) == map_.end()) {
+      map_[web_contents] = scoped_refptr<payments::PaymentRequestImpl>(

[Lei Zhang, 2016/11/16 23:02:26]

You may be able to assign directly without explicitly creating a scoped_refptr.

[Kevin Bailey, 2016/11/17 15:05:42]

It's worse than that. It's incorrect to get rid of the intermediate variable.

+          new payments::PaymentRequestImpl(web_contents, std::move(request)));
+      return true;
+    }
+    return false;
+  }
+
+  void UnassignPaymentRequest(content::WebContents* web_contents) {
+    DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+    map_.erase(web_contents);
+  }
+
+ private:
+  std::map<content::WebContents*, scoped_refptr<payments::PaymentRequestImpl>>
+      map_;
+};
+
+base::LazyInstance<PaymentRequestFactory> payment_request_factory;
+
+}  // namespace
+
+namespace payments {
+
+PaymentRequestImpl::PaymentRequestImpl(
+    content::WebContents* web_contents,
+    mojo::InterfaceRequest<payments::mojom::PaymentRequest> request)
+    : web_contents_(web_contents),
+      binding_(this, std::move(request)),
+      dialog_(nullptr) {
+  binding_.set_connection_error_handler(
+      base::Bind(&PaymentRequestImpl::OnError, this));
+}
+
+PaymentRequestImpl::~PaymentRequestImpl() {}
+
+void PaymentRequestImpl::Init(
+    payments::mojom::PaymentRequestClientPtr client,
+    std::vector<payments::mojom::PaymentMethodDataPtr> methodData,
+    payments::mojom::PaymentDetailsPtr details,
+    payments::mojom::PaymentOptionsPtr options) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  dialog_ = new PaymentRequestDialog(std::move(client));
+  views::DialogDelegate::CreateDialogWidget(
+      dialog_, nullptr,
+      web_modal::WebContentsModalDialogManager::FromWebContents(web_contents_)
+          ->delegate()
+          ->GetWebContentsModalDialogHost()
+          ->GetHostView())
+      ->Show();
+}
+
+void PaymentRequestImpl::OnError() {
+  binding_.Close();
+  // TODO(krb): Call dialog_->Close() here, but avoid double-free
+  payment_request_factory.Get().UnassignPaymentRequest(web_contents_);
+}
+
+}  // namespace payments
+
+void CreatePaymentRequestHandler(
+    content::WebContents* web_contents,
+    mojo::InterfaceRequest<payments::mojom::PaymentRequest> request) {
+  payment_request_factory.Get().AssignPaymentRequest(web_contents,
+                                                     std::move(request));
+}