components/payments/BUILD.gn - Issue 2446093004: [Web Payments] Initial plumb of Payment Request dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/payments/BUILD.gn

Issue 2446093004: [Web Payments] Initial plumb of Payment Request dialog (Closed)

Patch Set: Replaced my flag with existing one Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//mojo/public/tools/bindings/mojom.gni")	5 import("//mojo/public/tools/bindings/mojom.gni")

6	6

7 mojom("payment_request") {	7 mojom("payment_request") {

8 sources = [	8 sources = [

9 "payment_request.mojom",	9 "payment_request.mojom",

10 ]	10 ]

11	11

12 public_deps = [	12 public_deps = [

13 "//mojo/common:common_custom_types",	13 "//mojo/common:common_custom_types",

14 ]	14 ]

15 }	15 }

	16

	17 static_library("payments") {

	18 sources = [

	19 # Place-holder.
	please use gerrit instead 2016/11/04 21:58:15 Does this patch not compile the newly added files? Does this patch not compile the newly added files? Kevin Bailey 2016/11/09 16:25:21 The new files are over in chrome/browser/payments Show quoted text On 2016/11/04 21:58:15, rouslan wrote: > Does this patch not compile the newly added files? The new files are over in chrome/browser/payments (and are compiled and tested, of course) so the question confuses me. The purpose of this placeholder is so the other directories can depend on a single stable target, and we can change it without bothering other owners unnecessarily.
	20 ]

	21 deps = [

	22 ":payment_request",

	23 ]

	24 }

OLD	NEW