[Web Payments] Initial plumb of Payment Request dialog

chrome/browser/payments/payment_request_impl.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[please use gerrit instead, 2016/11/04 21:58:13]

"(c)" is no longer recommended in license header.

[Kevin Bailey, 2016/11/09 16:25:21]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAYMENTS_PAYMENT_REQUEST_IMPL_H_
+#define CHROME_BROWSER_PAYMENTS_PAYMENT_REQUEST_IMPL_H_
+
+#include "components/payments/payment_request.mojom.h"
+
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/web_contents.h"
+#include "mojo/public/cpp/bindings/binding.h"
+
+class PaymentRequestImpl : blink::mojom::PaymentRequest {
+ public:
+  PaymentRequestImpl(
+      content::RenderFrameHost* render_frame_host,
+      content::WebContents* web_contents,
+      mojo::InterfaceRequest<blink::mojom::PaymentRequest> request);

[please use gerrit instead, 2016/11/04 21:58:13]

// blink::mojom::PaymentRequest implementation:

(Groups of methods marked with "override" are usually adorned with a single-line
comment that points out the interface that they are implementing. That way, in
absence of a modern IDE, a reader would know where to look for the documentation
on these methods.)

[Kevin Bailey, 2016/11/09 16:25:21]

Done.

+  void Init(blink::mojom::PaymentRequestClientPtr client,
+            std::vector<blink::mojom::PaymentMethodDataPtr> methodData,
+            blink::mojom::PaymentDetailsPtr details,
+            blink::mojom::PaymentOptionsPtr options) override;
+  void Show() override {}
+  void UpdateWith(blink::mojom::PaymentDetailsPtr details) override {}
+  void Abort() override {}
+  void Complete(blink::mojom::PaymentComplete result) override {}
+
+  ~PaymentRequestImpl() override;

[please use gerrit instead, 2016/11/04 21:58:13]

Style nit: The destructor should follow the constructor.

[Kevin Bailey, 2016/11/09 16:25:21]

Done.

+
+ private:
+//  content::RenderFrameHost* render_frame_host_;

[please use gerrit instead, 2016/11/04 21:58:14]

Remove?

[Kevin Bailey, 2016/11/09 16:25:21]

Done.

+  content::WebContents* web_contents_;

[please use gerrit instead, 2016/11/04 21:58:13]

Do you happen to know the ownership relationship of web_contents_ an this
PaymentRequestImpl object? I want to say "web_contents_ owns this object", but
not sure. This kind of information would be useful in a comment. If you're not
using this variable anywhere, better just remove it to avoid trouble ;-)

[Kevin Bailey, 2016/11/09 16:25:21]

I was going to deal with ownership later, thus the TODO.

It's used in ::Init().

+  mojo::Binding<blink::mojom::PaymentRequest> binding_;

[please use gerrit instead, 2016/11/04 21:58:13]

DISALLOW_COPY_AND_ASSIGN(PaymentRequestImpl);

(Always helps with memory management snafoos.)

[Kevin Bailey, 2016/11/09 16:25:20]

Done.

+};
+
+void CreatePaymentRequestHandler(
+    content::RenderFrameHost* render_frame_host,
+    content::WebContents* web_contents,
+    mojo::InterfaceRequest<blink::mojom::PaymentRequest> request);
+
+#endif // CHROME_BROWSER_PAYMENTS_PAYMENT_REQUEST_IMPL_H_