[Web Payments] Initial plumb of Payment Request dialog

chrome/browser/payments/payment_request_impl.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAYMENTS_PAYMENT_REQUEST_IMPL_H_
+#define CHROME_BROWSER_PAYMENTS_PAYMENT_REQUEST_IMPL_H_
+
+#include "components/payments/payment_request.mojom.h"
+#include "mojo/public/cpp/bindings/binding.h"
+
+namespace content {
+class WebContents;
+}
+
+namespace payments {
+
+class PaymentRequestDialog;
+
+class PaymentRequestImpl : payments::mojom::PaymentRequest,
+                           public base::RefCounted<PaymentRequestImpl> {
+ public:
+  PaymentRequestImpl(
+      content::WebContents* web_contents,
+      mojo::InterfaceRequest<payments::mojom::PaymentRequest> request);
+
+ private:
+  friend class base::RefCounted<PaymentRequestImpl>;

[Lei Zhang, 2016/11/16 00:59:33]

Most often, existing code just put these in the private block below, rather than
having public/private/public/private.

[Kevin Bailey, 2016/11/16 14:13:47]

I moved it here because Rouslan suggested that the destructor should
be after the constructor.

[Lei Zhang, 2016/11/16 18:39:30]

At the time of that suggestion, the destructor was public, but now you made it
private, so it does not make sense style-wise to keep them together anymore.

[Kevin Bailey, 2016/11/16 22:34:09]

I understand. Done. I assume we still want the destructor after the
constructor in the .cc file, to easily see that everything was undone.

+  ~PaymentRequestImpl() override;
+
+ public:
+  // payments::mojom::PaymentRequest "stub"
+  void Init(payments::mojom::PaymentRequestClientPtr client,
+            std::vector<payments::mojom::PaymentMethodDataPtr> methodData,
+            payments::mojom::PaymentDetailsPtr details,
+            payments::mojom::PaymentOptionsPtr options) override;
+  void Show() override {}
+  void UpdateWith(payments::mojom::PaymentDetailsPtr details) override {}
+  void Abort() override {}
+  void Complete(payments::mojom::PaymentComplete result) override {}
+  void onError();

[Lei Zhang, 2016/11/16 00:59:33]

OnError() ? Is this suppose to be part of the mojom thing?

[Kevin Bailey, 2016/11/16 14:13:47]

I capitalized it in case that's what you're hinting at.
Otherwise, not sure what you're asking.

[Lei Zhang, 2016/11/16 18:39:30]

There's no override keyword, so I wasn't sure if it's actually related to the
other methods.

[Kevin Bailey, 2016/11/16 22:34:09]

I didn't space it away either. Fixed.

+
+ private:
+  content::WebContents* web_contents_;
+  mojo::Binding<payments::mojom::PaymentRequest> binding_;
+  PaymentRequestDialog* dialog_;
+  DISALLOW_COPY_AND_ASSIGN(PaymentRequestImpl);
+};
+
+}  // namespace payments
+
+void CreatePaymentRequestHandler(
+    content::WebContents* web_contents,
+    mojo::InterfaceRequest<payments::mojom::PaymentRequest> request);
+
+#endif  // CHROME_BROWSER_PAYMENTS_PAYMENT_REQUEST_IMPL_H_