[Web Payments] Initial plumb of Payment Request dialog

chrome/browser/payments/ui/payment_request_dialog.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAYMENTS_UI_PAYMENT_REQUEST_DIALOG_H_
+#define CHROME_BROWSER_PAYMENTS_UI_PAYMENT_REQUEST_DIALOG_H_
+
+#include "components/payments/payment_request.mojom.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace payments {
+
+class PaymentRequestDialog : public views::DialogDelegateView {
+ public:
+  explicit PaymentRequestDialog(
+      payments::mojom::PaymentRequestClientPtr client);
+  ~PaymentRequestDialog() override;
+
+  ui::ModalType GetModalType() const override;

[Lei Zhang, 2016/11/15 19:20:47]

style: groups the overrides together:

// views::DialogDelegateView:
foo Foo() override;
bar Bar() override;

[Kevin Bailey, 2016/11/15 20:33:55]

I separated them to indicate that they all came from different
places (my fault for not specifying where.) I don't see how
(in this case) saying that the overrides come from the one and
only base class informs the reader of anything. This way rather
hides their origin.

[Lei Zhang, 2016/11/15 21:25:06]

Oh, I didn't the realize the DialogDelegateView hierachy is so complicated. You
can certainly separate it out again, but add comments to label what's overriding
what.

+
+  gfx::Size GetPreferredSize() const override;
+
+  bool Cancel() override;
+
+ private:
+  payments::mojom::PaymentRequestClientPtr client_;
+  std::unique_ptr<views::Label> label_;
+
+  DISALLOW_COPY_AND_ASSIGN(PaymentRequestDialog);
+};
+
+}  // namespace payments
+
+#endif  // CHROME_BROWSER_PAYMENTS_UI_PAYMENT_REQUEST_DIALOG_H_