Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2446093003: Adapt analyzer to new warnings around switch-case fallthrough. (Closed)

Created:
4 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix warning due to assignment preventing type promotion. #

Patch Set 3 : Mark test no longer causing a warning. #

Patch Set 4 : Mark another test as now passing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tests/co19/co19-analyzer2.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-10-26 07:45:52 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-10-26 08:20:10 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 1322877f5b3a8c741d73df861169c494311073e8 (presubmit successful).
4 years, 1 month ago (2016-10-26 08:51:54 UTC) #5
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 1f7d8924c6e724e11dab4c266d79aac9441a3bd3 (presubmit successful).
4 years, 1 month ago (2016-10-26 09:31:01 UTC) #7
Lasse Reichstein Nielsen
Committed patchset #3 (id:40001) manually as 9c2306c7dca5c76c75039e2450165f53610bab9e (presubmit successful).
4 years, 1 month ago (2016-10-26 10:56:59 UTC) #9
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-10-26 12:03:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
22a57bbe2c279ca6d138994a708fdc19c5caadf2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698