src/code-stubs.cc - Issue 2446073002: [stubs] Add more assertions in the CodeStubAssembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs.cc

Issue 2446073002: [stubs] Add more assertions in the CodeStubAssembler (Closed)

Patch Set: adding slow asserts Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stubs.cc

diff --git a/src/code-stubs.cc b/src/code-stubs.cc

index 8be594365033670534ccbdb81947815dbfc521c2..b007ddcbea37f60122143f55a8d5d94a8fb4e8b8 100644

--- a/src/code-stubs.cc

+++ b/src/code-stubs.cc

@@ -2035,7 +2035,7 @@ void StoreGlobalStub::GenerateAssembly(CodeStubAssembler* assembler) const {

Node* global = assembler->LoadObjectField(proxy_map, Map::kPrototypeOffset);

Node* map_cell = assembler->HeapConstant(isolate()->factory()->NewWeakCell(

StoreGlobalStub::global_map_placeholder(isolate())));

- Node* expected_map = assembler->LoadWeakCellValue(map_cell);

+ Node* expected_map = assembler->LoadWeakCellValueUnchecked(map_cell);

Node* map = assembler->LoadMap(global);

assembler->GotoIf(assembler->WordNotEqual(expected_map, map), &miss);

}