chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java - Issue 2446063002: Implement a modal permission dialog on Android gated by a feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java

Issue 2446063002: Implement a modal permission dialog on Android gated by a feature. (Closed)

Patch Set: Move delegate creation and dispatch into constructor Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/permission_dialog.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java

index 06b96190c33b04f15504340f35089695ba46e35b..bb5880d610d1dee826d058064ae5e5b324c612f1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java

@@ -56,7 +56,7 @@ public class PermissionInfoBar extends ConfirmInfoBar {

if (mShowPersistenceToggle) {

InfoBarControlLayout controlLayout = layout.addControlLayout();

String description =

- layout.getContext().getString(R.string.permission_infobar_persist_text);

+ layout.getContext().getString(R.string.permission_prompt_persist_text);

controlLayout.addSwitch(

0, 0, description, R.id.permission_infobar_persist_toggle, true);

}