chrome/android/java/res/layout/permission_dialog.xml - Issue 2446063002: Implement a modal permission dialog on Android gated by a feature.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/permission_dialog.xml

Issue 2446063002: Implement a modal permission dialog on Android gated by a feature. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogDelegate.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:orientation="vertical"

	8 android:gravity="start"

	9 style="@style/AlertDialogContent" >

	10

	11 <TextView

	12 android:id="@+id/text"

	13 android:layout_width="match_parent"

	14 android:layout_height="wrap_content"

	15 android:layout_marginEnd="@dimen/infobar_control_margin_between_items"

	16 android:gravity="center_vertical"

	17 android:textSize="@dimen/infobar_text_size"

	18 android:paddingTop="0dp"

	19 android:drawablePadding="8dp"

	20 android:layout_marginTop="10dp" />
	gone 2016/10/27 20:33:34 nit: move this margin up next to the other layout_ nit: move this margin up next to the other layout_ params dominickn 2016/10/27 23:37:12 Done. Show quoted text On 2016/10/27 20:33:34, dfalcantara (slow 10.24) wrote: > nit: move this margin up next to the other layout_ params Done.
	21

	22 <LinearLayout

	23 android:layout_width="match_parent"

	24 android:layout_height="wrap_content"

	25 android:layout_marginTop="8dp"

	26 android:paddingStart="8dp"

	27 android:gravity="bottom">

	28

	29 <TextView

	30 android:id="@+id/permission_dialog_persist_message"

	31 android:layout_width="0dp"

	32 android:layout_height="wrap_content"

	33 android:layout_weight="1"

	34 android:layout_marginEnd="@dimen/infobar_control_margin_between_item s"

	35 android:gravity="center_vertical"

	36 android:textSize="@dimen/infobar_text_size" />

	37

	38 <android.support.v7.widget.SwitchCompat

	39 android:id="@+id/permission_dialog_persist_toggle"

	40 android:layout_width="wrap_content"

	41 android:layout_height="wrap_content" />

	42

	43 </LinearLayout>

	44 </LinearLayout>

OLD	NEW