cherry picking changes needed for deps roll.

cherry picking changes needed for deps roll.

DEPS roll is needed for mips builds.  These additional changes are also
needed for that DEPS roll.  These can be done separately.

TBR=kjellander@chromium.org
BUG=libyuv:634
TEST=try bots

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/7c309c459f3f4542a791c3224d29ed95e30aa8c0

[fbarchard1, 2016-10-25 22:54:30]

fbarchard@google.com changed reviewers:
+ kjellander@chromium.org

[fbarchard1, 2016-10-25 22:54:31]

linux gcc fails with:

 USER: chrome-bot
 USERNAME: chrome-bot

ERROR at //build/config/sysroot.gni:70:5: Assertion failed.
    assert(is_clang, "sysroot images require clang (try use_sysroot=false)")
    ^-----
sysroot images require clang (try use_sysroot=false)



This is how I'm building gcc
gn gen out/Release "--args=is_debug=false is_clang=false use_sysroot=false
target_cpu=\"x64\""
gn gen out/Debug "--args=is_debug=true is_clang=false use_sysroot=false
target_cpu=\"x64\""
ninja -C out/Debug
ninja -v -C out/Release

[fbarchard1, 2016-10-25 22:54:47]

Description was changed from

==========
cherry picking changes needed for deps roll.

DEPS roll is needed for mips builds.  These additional changes are also
needed for that DEPS roll.  These can be done separately.

BUG=libyuv:634
TEST=try bots
==========

to

==========
cherry picking changes needed for deps roll.

DEPS roll is needed for mips builds.  These additional changes are also
needed for that DEPS roll.  These can be done separately.

TBR=kjellander@chromium.org
BUG=libyuv:634
TEST=try bots
==========

[fbarchard1, 2016-10-25 22:55:01]

Description was changed from

==========
cherry picking changes needed for deps roll.

DEPS roll is needed for mips builds.  These additional changes are also
needed for that DEPS roll.  These can be done separately.

TBR=kjellander@chromium.org
BUG=libyuv:634
TEST=try bots
==========

to

==========
cherry picking changes needed for deps roll.

DEPS roll is needed for mips builds.  These additional changes are also
needed for that DEPS roll.  These can be done separately.

TBR=kjellander@chromium.org
BUG=libyuv:634
TEST=try bots

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/7c309c459f3f4542a791c3224d2...
==========

[fbarchard1, 2016-10-25 22:55:02]

Committed patchset #2 (id:20001) manually as
7c309c459f3f4542a791c3224d29ed95e30aa8c0 (presubmit successful).

[kjellander_chromium, 2016-10-26 05:21:52]

On 2016/10/25 22:54:31, fbarchard1 wrote:
> linux gcc fails with:
> 
>  USER: chrome-bot
>  USERNAME: chrome-bot
> 
> ERROR at //build/config/sysroot.gni:70:5: Assertion failed.
>     assert(is_clang, "sysroot images require clang (try use_sysroot=false)")
>     ^-----
> sysroot images require clang (try use_sysroot=false)
> 
> 
> 
> This is how I'm building gcc
> gn gen out/Release "--args=is_debug=false is_clang=false use_sysroot=false
> target_cpu=\"x64\""
> gn gen out/Debug "--args=is_debug=true is_clang=false use_sysroot=false
> target_cpu=\"x64\""
> ninja -C out/Debug
> ninja -v -C out/Release

Yeah, we haven't yet figured out gcc yet. It's not a default trybot so it
shouldn't affect the build (there is no post-commit bot using GCC)

[kjellander_chromium, 2016-10-26 05:22:10]

lgtm