Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2446033002: Try disabling GPU watchdog in WebGL conformance tests. (Closed)

Created:
4 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try disabling GPU watchdog in WebGL conformance tests. It's believed that the flaky GPU process hangs seen on the waterfall are spurious, not real. Try disabling the GPU watchdog. If the hangs are real, this will result in test timeouts rather than GPU process crashes, context loss, and test failures. BUG=596622, 609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/51e832338dfaeedf418778541a10003fd1feef8b Cr-Commit-Position: refs/heads/master@{#427247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Ken Russell (switch to Gerrit)
PTAL
4 years, 1 month ago (2016-10-25 01:09:52 UTC) #3
Zhenyao Mo
On 2016/10/25 01:09:52, Ken Russell wrote: > PTAL OK, let's try this lgtm
4 years, 1 month ago (2016-10-25 01:11:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446033002/1
4 years, 1 month ago (2016-10-25 01:14:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 02:35:21 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 02:39:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51e832338dfaeedf418778541a10003fd1feef8b
Cr-Commit-Position: refs/heads/master@{#427247}

Powered by Google App Engine
This is Rietveld 408576698