|
|
Created:
4 years, 1 month ago by skobes Modified:
4 years, 1 month ago Reviewers:
tandrii(chromium) CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Dirk Pranke Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionContinue to the next file after a conflict in apply_patch.
BUG=658915
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2f3f137de7a627772cd37801530a4ce6458c5d81
Patch Set 1 #
Total comments: 2
Patch Set 2 : address nit #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/321284b16daa5d10)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Collect multiple failures. BUG=658915 ========== to ========== Continue to the next file after a conflict in apply_patch. BUG=658915 ==========
skobes@chromium.org changed reviewers: + tandrii@chromium.org
lgtm https://codereview.chromium.org/2446013002/diff/40001/checkout.py File checkout.py (right): https://codereview.chromium.org/2446013002/diff/40001/checkout.py#newcode88 checkout.py:88: (p, status) = e nit: no need for ()
https://codereview.chromium.org/2446013002/diff/40001/checkout.py File checkout.py (right): https://codereview.chromium.org/2446013002/diff/40001/checkout.py#newcode88 checkout.py:88: (p, status) = e On 2016/10/25 09:52:44, tandrii(chromium) wrote: > nit: no need for () Done.
The CQ bit was checked by skobes@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org Link to the patchset: https://codereview.chromium.org/2446013002/#ps60001 (title: "address nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Continue to the next file after a conflict in apply_patch. BUG=658915 ========== to ========== Continue to the next file after a conflict in apply_patch. BUG=658915 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2f3f137de7a627... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/2f3f137de7a627... |