Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2446013002: Continue to the next file after a conflict in apply_patch. (Closed)

Created:
4 years, 1 month ago by skobes
Modified:
4 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Dirk Pranke
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Continue to the next file after a conflict in apply_patch. BUG=658915 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2f3f137de7a627772cd37801530a4ce6458c5d81

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M checkout.py View 1 3 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
skobes
4 years, 1 month ago (2016-10-25 02:56:10 UTC) #13
tandrii(chromium)
lgtm https://codereview.chromium.org/2446013002/diff/40001/checkout.py File checkout.py (right): https://codereview.chromium.org/2446013002/diff/40001/checkout.py#newcode88 checkout.py:88: (p, status) = e nit: no need for ...
4 years, 1 month ago (2016-10-25 09:52:44 UTC) #14
skobes
https://codereview.chromium.org/2446013002/diff/40001/checkout.py File checkout.py (right): https://codereview.chromium.org/2446013002/diff/40001/checkout.py#newcode88 checkout.py:88: (p, status) = e On 2016/10/25 09:52:44, tandrii(chromium) wrote: ...
4 years, 1 month ago (2016-10-25 15:05:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446013002/60001
4 years, 1 month ago (2016-10-25 15:05:34 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 15:08:31 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/2f3f137de7a627...

Powered by Google App Engine
This is Rietveld 408576698