Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3193)

Unified Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Issue 2446003002: settings-dropdown-menu must set <select>#value after its options change (Closed)
Patch Set: Hide custom option via CSS Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/settings_dropdown_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.html
diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
index a772446aa15bfdd83ff13fced48d7a79313dd945..6120ebaaa1f426145c4f12afb0778ff273456605 100644
--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
@@ -7,16 +7,20 @@
<dom-module id="settings-dropdown-menu">
<template>
- <style include="settings-shared md-select"></style>
+ <style include="settings-shared md-select">
+ /* Hide "Custom" value when unselectable. */
+ option:disabled {
+ display: none;
+ }
+ </style>
<div class="md-select-wrapper">
<select class="md-select" id="dropdownMenu" on-change="onChange_"
- value="[[selected_]]"
disabled="[[shouldDisableMenu_(disabled, menuOptions)]]">
<template is="dom-repeat" items="[[menuOptions]]">
<option value="[[item.value]]">[[item.name]]</option>
</template>
<option value="[[notFoundValue_]]"
- hidden$="[[!isSelectedNotFound_(selected_)]]">
+ disabled="[[!showNotFoundValue_(menuOptions, pref.value)]]">
$i18n{custom}
</option>
</select>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/settings_dropdown_menu.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698