Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: pkg/barback/test/package_graph/transform_test.dart

Issue 24460004: Fix a barback bug where a result could be emitted incorrectly. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/package_graph.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/package_graph/transform_test.dart
diff --git a/pkg/barback/test/package_graph/transform_test.dart b/pkg/barback/test/package_graph/transform_test.dart
index af8df48ecab6cc2fa88575f85ba6031b92662d06..14aff9fabcf1a105b5433590b35af02a742ec347 100644
--- a/pkg/barback/test/package_graph/transform_test.dart
+++ b/pkg/barback/test/package_graph/transform_test.dart
@@ -1002,6 +1002,29 @@ main() {
buildShouldSucceed();
});
+ test("doesn't complete the build until all packages' transforms are "
+ "finished running", () {
+ var transformer = new ManyToOneTransformer("txt");
+ initGraph({
+ "pkg1|a.txt": "pkg2|a.inc",
+ "pkg2|a.inc": "a"
+ }, {
+ "pkg1": [[transformer]]
+ });
+
+ updateSources(["pkg1|a.txt", "pkg2|a.inc"]);
+ expectAsset("pkg1|a.out", "a");
+ buildShouldSucceed();
+
+ transformer.pauseApply();
+ modifyAsset("pkg2|a.inc", "new a");
+ updateSources(["pkg2|a.inc"]);
+ buildShouldNotBeDone();
+
+ transformer.resumeApply();
+ buildShouldSucceed();
+ });
+
test("runs a transform that's added because of a change in another package",
() {
initGraph({
« no previous file with comments | « pkg/barback/lib/src/package_graph.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698