Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: pkg/barback/lib/src/package_graph.dart

Issue 24460004: Fix a barback bug where a result could be emitted incorrectly. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/asset_cascade.dart ('k') | pkg/barback/test/package_graph/transform_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/package_graph.dart
diff --git a/pkg/barback/lib/src/package_graph.dart b/pkg/barback/lib/src/package_graph.dart
index 5afe5f41be0b23bb190d5646e71d83d426f59fd7..2cd5b46b370e2eac2d4f8082c8859efcdf0d105e 100644
--- a/pkg/barback/lib/src/package_graph.dart
+++ b/pkg/barback/lib/src/package_graph.dart
@@ -69,6 +69,9 @@ class PackageGraph {
// doesn't start building until some source in that graph is updated.
_cascadeResults[package] = new BuildResult.success();
_cascades[package] = cascade;
+ cascade.onDirty.listen((_) {
+ _cascadeResults[package] = null;
+ });
cascade.results.listen((result) {
_cascadeResults[cascade.package] = result;
@@ -144,7 +147,6 @@ class PackageGraph {
groupBy(sources, (id) => id.package).forEach((package, ids) {
var cascade = _cascades[package];
if (cascade == null) throw new ArgumentError("Unknown package $package.");
- _cascadeResults[package] = null;
cascade.updateSources(ids);
});
}
@@ -154,14 +156,12 @@ class PackageGraph {
groupBy(sources, (id) => id.package).forEach((package, ids) {
var cascade = _cascades[package];
if (cascade == null) throw new ArgumentError("Unknown package $package.");
- _cascadeResults[package] = null;
cascade.removeSources(ids);
});
}
void updateTransformers(String package,
Iterable<Iterable<Transformer>> transformers) {
- _cascadeResults[package] = null;
_cascades[package].updateTransformers(transformers);
}
}
« no previous file with comments | « pkg/barback/lib/src/asset_cascade.dart ('k') | pkg/barback/test/package_graph/transform_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698