Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 2445993006: [WIP] Upgrade-insecure-request: upgrade insecurely-redirected requests.

Created:
4 years, 1 month ago by arthursonzogni
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, creis+watch_chromium.org, wjmaclean, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), blink-reviews-api_chromium.org, blink-reviews, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, loading-reviews_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Upgrade-insecure-request: upgrade insecurely-redirected requests. * Adds two Layout tests that check that redirected requests are upgraded. It covers the bug: crbug.com/659684. * Fixes the bug for both resource requests and navigational requests. * Upgrade requests on the PlzNavigate path (browser-side-navigation) too. For information, this CL **partially** fixes the tests: * http/tests/navigation/post-frame-goback1.html * virtual/stable/http/tests/navigation/post-frames-goback1.html with --enable-browser-side-navigation flag. BUG=659684, 576261 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 : [WIP] Upgrade-insecure-request: upgrade insecurely-redirected requests. #

Patch Set 2 : bugfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -33 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_request.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 5 chunks +32 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_request_info.h View 3 chunks +15 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_request_info.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/loader/async_resource_handler_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 3 chunks +8 lines, -1 line 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 3 chunks +6 lines, -3 lines 0 comments Download
A content/browser/net/url_request_insecure_interceptor.h View 1 chunk +37 lines, -0 lines 0 comments Download
A content/browser/net/url_request_insecure_interceptor.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/resource_request.h View 2 chunks +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/upgrade-insecure-requests/basic-upgrade-redirect.html View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/upgrade-insecure-requests/iframe-upgrade-redirect.https.html View 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLRequest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLRequest.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (15 generated)
arthursonzogni
Description was changed from ========== [WIP] Upgrade-insecure-request: upgrade insecurely-redirected requests. * Adds two Layout tests ...
4 years, 1 month ago (2016-10-27 13:41:13 UTC) #1
arthursonzogni
Description was changed from ========== [WIP] Upgrade-insecure-request: upgrade insecurely-redirected requests. * Adds two Layout tests ...
4 years, 1 month ago (2016-10-27 13:47:33 UTC) #2
arthursonzogni
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-27 14:39:23 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445993006/1
4 years, 1 month ago (2016-10-27 14:39:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-27 15:59:40 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/249921)
4 years, 1 month ago (2016-10-27 15:59:41 UTC) #6
arthursonzogni
Patchset #1 (id:1) has been deleted
4 years, 1 month ago (2016-10-27 16:28:43 UTC) #7
arthursonzogni
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-27 16:28:59 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445993006/20001
4 years, 1 month ago (2016-10-27 16:29:17 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-27 17:17:24 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/169202)
4 years, 1 month ago (2016-10-27 17:17:25 UTC) #11
arthursonzogni
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-28 08:29:22 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445993006/40001
4 years, 1 month ago (2016-10-28 08:29:39 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-28 11:03:47 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 11:03:48 UTC) #15
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698