Make sure we get at least one progress callback

Make sure we get at least one progress callback

When media is already cached, we don't get any progress callbacks,
which confuse clients. Make sure we get at least one progress
callback.

This CL is an update of cr/2437273002, which solves a similiar problem.

BUG=657922, 658950
Committed: https://crrev.com/0c2a4c4bbc9abafc57dfc3dd919ffff1e23fd664
Cr-Commit-Position: refs/heads/master@{#428773}

[hubbe, 2016-10-25 20:25:53]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[hubbe, 2016-10-25 20:26:09]

hubbe@chromium.org changed reviewers:
+ chcunningham@chromium.org

[commit-bot: I haz the power, 2016-10-25 20:26:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 20:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 20:48:47]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[chcunningham, 2016-10-26 18:42:39]

Thanks Hubbe

LGTM

[hubbe, 2016-10-26 19:00:40]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 19:01:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:34:00]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[hubbe, 2016-10-27 21:45:24]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 21:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2016-10-27 21:46:23]

Turns out I broke a bunch of tests. This modified version should work better.
PTAL.

[commit-bot: I haz the power, 2016-10-27 22:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:09:27]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[hubbe, 2016-10-27 23:53:40]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:54:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 01:06:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:06:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chcunningham, 2016-10-28 17:53:53]

https://codereview.chromium.org/2445993003/diff/40001/media/blink/multibuffer...
File media/blink/multibuffer_data_source.cc (right):

https://codereview.chromium.org/2445993003/diff/40001/media/blink/multibuffer...
media/blink/multibuffer_data_source.cc:525: if (assume_fully_buffered())
The tests in the bug have both been http://, but I think the expectations around
progress/loading events are the same even for local files. I'm worried this
early return is bad for the local case.

[hubbe, 2016-10-31 17:25:17]

https://codereview.chromium.org/2445993003/diff/40001/media/blink/multibuffer...
File media/blink/multibuffer_data_source.cc (right):

https://codereview.chromium.org/2445993003/diff/40001/media/blink/multibuffer...
media/blink/multibuffer_data_source.cc:525: if (assume_fully_buffered())
On 2016/10/28 17:53:52, chcunningham wrote:
> The tests in the bug have both been http://, but I think the expectations
around
> progress/loading events are the same even for local files. I'm worried this
> early return is bad for the local case.

I'm not entirely sure why we do this, but it's been like this since before
multibuffers. It might be worth noticing that we never even
transition into the "loading" state for local resources. However, we might need
to add layout tests that runs on local files to make sure that WMPI behaves
properly when it gets no loading or progress callbacks.

[chcunningham, 2016-10-31 18:12:39]

lgtm

https://codereview.chromium.org/2445993003/diff/40001/media/blink/multibuffer...
File media/blink/multibuffer_data_source.cc (right):

https://codereview.chromium.org/2445993003/diff/40001/media/blink/multibuffer...
media/blink/multibuffer_data_source.cc:525: if (assume_fully_buffered())
On 2016/10/31 17:25:17, hubbe wrote:
> On 2016/10/28 17:53:52, chcunningham wrote:
> > The tests in the bug have both been http://, but I think the expectations
> around
> > progress/loading events are the same even for local files. I'm worried this
> > early return is bad for the local case.
> 
> I'm not entirely sure why we do this, but it's been like this since before
> multibuffers. It might be worth noticing that we never even
> transition into the "loading" state for local resources. However, we might
need
> to add layout tests that runs on local files to make sure that WMPI behaves
> properly when it gets no loading or progress callbacks.

Acknowledged.

[hubbe, 2016-10-31 18:13:43]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:14:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 19:50:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-31 20:00:05]

Description was changed from

==========
Make sure we get at least one progress callback

When media is already cached, we don't get any progress callbacks,
which confuse clients. Make sure we get at least one progress
callback.

This CL is an update of cr/2437273002, which solves a similiar problem.

BUG=657922, 658950
==========

to

==========
Make sure we get at least one progress callback

When media is already cached, we don't get any progress callbacks,
which confuse clients. Make sure we get at least one progress
callback.

This CL is an update of cr/2437273002, which solves a similiar problem.

BUG=657922, 658950

Committed: https://crrev.com/0c2a4c4bbc9abafc57dfc3dd919ffff1e23fd664
Cr-Commit-Position: refs/heads/master@{#428773}
==========

[commit-bot: I haz the power, 2016-10-31 20:00:07]

Patchset 3 (id:??) landed as
https://crrev.com/0c2a4c4bbc9abafc57dfc3dd919ffff1e23fd664
Cr-Commit-Position: refs/heads/master@{#428773}