Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: net/quic/core/quic_sent_packet_manager_test.cc

Issue 2445983003: Default enable QUIC's Cubic in bytes congestion control implementation. Protected by ENABLED FLAGS… (Closed)
Patch Set: Updated patchset dependency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_sent_packet_manager.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_sent_packet_manager_test.cc
diff --git a/net/quic/core/quic_sent_packet_manager_test.cc b/net/quic/core/quic_sent_packet_manager_test.cc
index 3e03eaf26d26d6b30dd64e3438b7f3fe815b431a..de79cb661168e6232175cb0cce4da1053a0a5d74 100644
--- a/net/quic/core/quic_sent_packet_manager_test.cc
+++ b/net/quic/core/quic_sent_packet_manager_test.cc
@@ -83,7 +83,7 @@ class QuicSentPacketManagerTest : public ::testing::TestWithParam<TestParams> {
kDefaultPathId,
&clock_,
&stats_,
- kCubic,
+ FLAGS_quic_default_enable_cubic_bytes ? kCubicBytes : kCubic,
kNack,
/*delegate=*/nullptr),
send_algorithm_(new StrictMock<MockSendAlgorithm>),
@@ -1443,8 +1443,13 @@ TEST_P(QuicSentPacketManagerTest, NegotiateCongestionControlFromOptions) {
QuicConfigPeer::SetReceivedConnectionOptions(&config, options);
EXPECT_CALL(*network_change_visitor_, OnCongestionChange());
manager_.SetFromConfig(config);
- EXPECT_EQ(kCubicBytes, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
- ->GetCongestionControlType());
+ if (FLAGS_quic_default_enable_cubic_bytes) {
+ EXPECT_EQ(kCubic, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
+ ->GetCongestionControlType());
+ } else {
+ EXPECT_EQ(kCubicBytes, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
+ ->GetCongestionControlType());
+ }
options.clear();
options.push_back(kRENO);
« no previous file with comments | « net/quic/core/quic_sent_packet_manager.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698