pkg-config-wrapper: use system_libdir for libpath

pkg-config-wrapper: use system_libdir for libpath

We already have a variable for tracking the system libdir name in the
gyp files, so let's use that instead of hardcoding the logic based on
the arch.

BUG=chromium:219015
TEST=`cbuildbot amd64-generic-tot-chrome-pfq-informational` works

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272792

[vapier, 2014-04-21 17:47:50]

casting a wide net here as each subdir has its own set of owners

[Daniel Erat, 2014-04-21 17:56:17]

lgtm

[acolwell GONE FROM CHROMIUM, 2014-04-21 22:00:07]

lgtm

[Ryan Sleevi, 2014-04-21 22:00:39]

lgtm

[Lei Zhang, 2014-04-21 22:09:15]

Do you need to change third_party/libjingle/source/talk/libjingle.gyp in this CL
too?

[jungshik at Google, 2014-04-21 22:33:56]

lgtm

[vapier, 2014-04-22 02:04:54]

hmm, i think so.  i was using `git grep` to locate files to update.  switched to
`find | grep`.

posted https://codereview.chromium.org/246343002/ and
https://webrtc-codereview.appspot.com/12259004/

[Paweł Hajdan Jr., 2014-04-22 13:58:49]

LGTM

[Paweł Hajdan Jr., 2014-04-22 13:58:49]

LGTM

[Lei Zhang, 2014-04-22 18:12:43]

lgtm

[DaveMoore, 2014-04-22 21:21:42]

lgtm

[vapier, 2014-05-25 02:38:07]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-05-25 02:38:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vapier@chromium.org/244593002/1

[commit-bot: I haz the power, 2014-05-25 06:03:52]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-25 06:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-25 06:09:49]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[vapier, 2014-05-25 12:59:13]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-05-25 12:59:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vapier@chromium.org/244593002/1

[commit-bot: I haz the power, 2014-05-25 13:05:14]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-25 13:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-25 13:31:45]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[vapier, 2014-05-26 02:45:38]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-05-26 02:46:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vapier@chromium.org/244593002/1

[commit-bot: I haz the power, 2014-05-26 04:37:46]

Change committed as 272792

[Alexander Potapenko, 2014-06-03 08:52:22]

This CL broke the chrooted ASan build with 32-bit V8, see
http://crbug.com/369119

https://codereview.chromium.org/244593002/diff/1/build/linux/pkg-config-wrapper
File build/linux/pkg-config-wrapper (right):

https://codereview.chromium.org/244593002/diff/1/build/linux/pkg-config-wrapp...
build/linux/pkg-config-wrapper:33: : ${libpath:="lib64"}
|libpath| (which is |system_libdir| is always "lib" on x86, x64 and ARM. Are you
dropping "lib64" deliberately?

[vapier, 2014-06-03 14:15:08]

https://codereview.chromium.org/244593002/diff/1/build/linux/pkg-config-wrapper
File build/linux/pkg-config-wrapper (right):

https://codereview.chromium.org/244593002/diff/1/build/linux/pkg-config-wrapp...
build/linux/pkg-config-wrapper:33: : ${libpath:="lib64"}
if system_libdir is being set to lib on x64, then the gyp files are broken
already -- this CL doesn't touch how it's being initialized.  i'll take a look
though.

[Alexander Potapenko, 2014-06-03 14:21:53]

On 2014/06/03 14:15:08, vapier wrote:
>
https://codereview.chromium.org/244593002/diff/1/build/linux/pkg-config-wrapper
> File build/linux/pkg-config-wrapper (right):
> 
>
https://codereview.chromium.org/244593002/diff/1/build/linux/pkg-config-wrapp...
> build/linux/pkg-config-wrapper:33: : ${libpath:="lib64"}
> if system_libdir is being set to lib on x64, then the gyp files are broken
> already -- this CL doesn't touch how it's being initialized.  i'll take a look
> though.

This was just a drive-by note unrelated to the gyp breakage.
I'm not sure what caused the harfbuzz gyp error.

[Alexander Potapenko, 2014-06-03 14:21:53]

On 2014/06/03 14:15:08, vapier wrote:
>
https://codereview.chromium.org/244593002/diff/1/build/linux/pkg-config-wrapper
> File build/linux/pkg-config-wrapper (right):
> 
>
https://codereview.chromium.org/244593002/diff/1/build/linux/pkg-config-wrapp...
> build/linux/pkg-config-wrapper:33: : ${libpath:="lib64"}
> if system_libdir is being set to lib on x64, then the gyp files are broken
> already -- this CL doesn't touch how it's being initialized.  i'll take a look
> though.

This was just a drive-by note unrelated to the gyp breakage.
I'm not sure what caused the harfbuzz gyp error.