Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 24459002: Reland linux_aura: Implement most of DesktopScreenX11. (Closed)

Created:
7 years, 3 months ago by Elliot Glaysher
Modified:
7 years, 2 months ago
Reviewers:
brettw, Daniel Erat, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, tfarina, oshima+watch_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Reland linux_aura: Implement most of DesktopScreenX11. [[Making changes to '_toolset=="target"' section in system.gyp to fix cros compiling.]] The linux_aura port didn't deal with multiple monitors very well because it was treating the X root window as one big display. When xrandr is present, get the screen areas from it, and exposes this data back to chrome. This patch also factors out the EDID parser than chromeos was using into a common directory. Like chromeos, we use it to assign stable display IDs. BUG=287972 TBR=brettw@chromium.org, derat@chromium.org, sky@chromium.org First Review URL: https://codereview.chromium.org/23536057 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225254

Patch Set 1 #

Patch Set 2 : Theoretical fix for chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+665 lines, -637 lines) Patch
M base/base.gyp View 2 chunks +13 lines, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
A base/x11/edid_parser_x11.h View 1 chunk +54 lines, -0 lines 0 comments Download
A + base/x11/edid_parser_x11.cc View 4 chunks +7 lines, -168 lines 0 comments Download
A + base/x11/edid_parser_x11_unittest.cc View 6 chunks +10 lines, -92 lines 0 comments Download
M build/linux/system.gyp View 1 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M chromeos/display/output_util.h View 2 chunks +0 lines, -22 lines 0 comments Download
M chromeos/display/output_util.cc View 4 chunks +5 lines, -186 lines 0 comments Download
M chromeos/display/output_util_unittest.cc View 2 chunks +1 line, -107 lines 0 comments Download
M chromeos/display/real_output_configurator_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_screen_x11.h View 1 chunk +95 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 2 chunks +235 lines, -56 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 1 chunk +186 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
(recommitting. only change is some minor changes to the gyp files to make cros_x86 happy. ...
7 years, 3 months ago (2013-09-25 03:17:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/24459002/3001
7 years, 3 months ago (2013-09-25 03:18:43 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171690
7 years, 3 months ago (2013-09-25 05:07:13 UTC) #3
Elliot Glaysher
7 years, 2 months ago (2013-09-25 21:32:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r225254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698