Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2445893002: Re-mark APKs as dangerous on Android (Closed)

Created:
4 years, 1 month ago by Nathan Parker
Modified:
4 years, 1 month ago
Reviewers:
asanka
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-mark APKs as dangerous on Android We can do this now that http://crbug.com/653961 is fixed. Revert "Revert "Mark APK downloads as dangerous on Android"" This reverts commit 84c632df136adb79c1282df0509daff8747e088c. BUG=652907 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/07e489926caff61e1c7f60df7a93ee29e2d13fd4 Cr-Commit-Position: refs/heads/master@{#427479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/resources/safe_browsing/download_file_types.asciipb View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nathan Parker
4 years, 1 month ago (2016-10-25 19:49:52 UTC) #4
asanka
lgtm
4 years, 1 month ago (2016-10-25 20:29:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445893002/1
4 years, 1 month ago (2016-10-25 20:35:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 21:25:26 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:30:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07e489926caff61e1c7f60df7a93ee29e2d13fd4
Cr-Commit-Position: refs/heads/master@{#427479}

Powered by Google App Engine
This is Rietveld 408576698