Raise dx's max java heap 1gb->2gb (-Xmx)

Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782
Committed: https://crrev.com/45b6982496b2209ee2846cc9ebeea8f82b23a732
Cr-Commit-Position: refs/heads/master@{#427182}

[agrieve, 2016-10-24 20:44:12]

Description was changed from

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782
==========

to

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782
==========

[agrieve, 2016-10-24 20:44:13]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-10-24 20:44:17]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 20:45:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2016-10-24 20:46:06]

https://codereview.chromium.org/2445883002/diff/1/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/2445883002/diff/1/build/android/gyp/dex.py#ne...
build/android/gyp/dex.py:215: dex_cmd = [dx_binary, '-JXmx2G',
'--num-threads=8', '--dex', '--force-jumbo',
JX?

[agrieve, 2016-10-24 20:47:34]

https://codereview.chromium.org/2445883002/diff/1/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/2445883002/diff/1/build/android/gyp/dex.py#ne...
build/android/gyp/dex.py:215: dex_cmd = [dx_binary, '-JXmx2G',
'--num-threads=8', '--dex', '--force-jumbo',
On 2016/10/24 20:46:06, jbudorick wrote:
> JX?

Yeah, it's because "dx" is a bash script that wraps the call to java. There's a
comment in the script showing how to set jvm args (via -J)

[jbudorick, 2016-10-24 20:48:36]

lgtm

https://codereview.chromium.org/2445883002/diff/1/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/2445883002/diff/1/build/android/gyp/dex.py#ne...
build/android/gyp/dex.py:215: dex_cmd = [dx_binary, '-JXmx2G',
'--num-threads=8', '--dex', '--force-jumbo',
On 2016/10/24 20:47:34, agrieve (OOO oct 17-21) wrote:
> On 2016/10/24 20:46:06, jbudorick wrote:
> > JX?
> 
> Yeah, it's because "dx" is a bash script that wraps the call to java. There's
a
> comment in the script showing how to set jvm args (via -J)

sgtm

[agrieve, 2016-10-24 20:51:55]

The CQ bit was unchecked by agrieve@chromium.org

[agrieve, 2016-10-24 20:51:58]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:52:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 20:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:58:41]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[agrieve, 2016-10-24 21:01:16]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:02:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 21:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:11:16]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jbudorick, 2016-10-24 21:33:11]

On 2016/10/24 21:11:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

this appears to be https://bugs.chromium.org/p/chromium/issues/detail?id=658865

[agrieve, 2016-10-24 22:26:53]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:27:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-10-24 23:42:34]

Description was changed from

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782
==========

to

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

NOTRY=true
BUG=658782
==========

[agrieve, 2016-10-24 23:42:57]

Description was changed from

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

NOTRY=true
BUG=658782
==========

to

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782
==========

[commit-bot: I haz the power, 2016-10-24 23:58:34]

Description was changed from

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782
==========

to

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782
==========

[commit-bot: I haz the power, 2016-10-24 23:58:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-24 23:59:59]

Description was changed from

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782
==========

to

==========
Raise dx's max java heap 1gb->2gb (-Xmx)

Some targets (e.g. unit_tests_apk) are starting to hit the limit!

BUG=658782

Committed: https://crrev.com/45b6982496b2209ee2846cc9ebeea8f82b23a732
Cr-Commit-Position: refs/heads/master@{#427182}
==========

[commit-bot: I haz the power, 2016-10-25 00:00:00]

Patchset 1 (id:??) landed as
https://crrev.com/45b6982496b2209ee2846cc9ebeea8f82b23a732
Cr-Commit-Position: refs/heads/master@{#427182}