Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2445853002: Add components_*tests and blimp_unittests to Site Isolation Android bot. (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, alexmos, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add components_*tests and blimp_unittests to Site Isolation Android bot. This is an attempt to add more tests run by Site Isolation Linux bot to the set of tests run by Site Isolation Android bot. Unfortunately, the following test targets are not built and run on Android: - app_shell_unittests, nacl_loader_unittests, sync_integration_tests - browser_tests, interactive_ui_tests, unit_tests - extensions_browsertests, extensions_unittests Therefore, only 3 test targets are being added to Site Isolation Android bot in this CL: - components_browsertests - components_unittests - blimp_unittests BUG=654569 Committed: https://crrev.com/1c13ffe7c4cbf8887dfeac1467df19131aaa521c Cr-Commit-Position: refs/heads/master@{#427381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Łukasz Anforowicz
nick@, can you take a look please?
4 years, 1 month ago (2016-10-24 20:45:09 UTC) #2
ncarter (slow)
lgtm
4 years, 1 month ago (2016-10-24 21:54:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445853002/1
4 years, 1 month ago (2016-10-24 22:07:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/151608)
4 years, 1 month ago (2016-10-25 00:35:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445853002/1
4 years, 1 month ago (2016-10-25 16:09:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 16:50:14 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 17:16:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c13ffe7c4cbf8887dfeac1467df19131aaa521c
Cr-Commit-Position: refs/heads/master@{#427381}

Powered by Google App Engine
This is Rietveld 408576698