chromeos: Convert "show other network" dialog to work with mash

chromeos: Convert "show other network" dialog to work with mash

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

Create a new NetworkConfigView::ShowForType to allow passing a container id.

Also clean up some unnecessary code around static initializers.

BUG=657021
TEST=open "join other" from system tray menu at login screen and after login

Committed: https://crrev.com/4f08d17c7ae7f28f341428276acab0f1aa3a0078
Cr-Commit-Position: refs/heads/master@{#427160}

[James Cook, 2016-10-24 19:57:37]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 19:58:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-24 20:12:34]

Description was changed from

==========
chromeos: Convert "show other network" dialog to work with mash

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

Create a new NetworkConfigView::ShowForType to allow passing a container id.

BUG=657021
TEST=open "join other" from system tray menu at login screen and after login
==========

to

==========
chromeos: Convert "show other network" dialog to work with mash

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

Create a new NetworkConfigView::ShowForType to allow passing a container id.

Also clean up some unnecessary code around static initializers.

BUG=657021
TEST=open "join other" from system tray menu at login screen and after login
==========

[James Cook, 2016-10-24 20:12:37]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 20:13:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-24 20:14:36]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-10-24 20:14:37]

stevenjb, please take a look.

https://codereview.chromium.org/2445843002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/options/network_config_view.cc (left):

https://codereview.chromium.org/2445843002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/options/network_config_view.cc:66: static
NetworkConfigView* active_dialog = nullptr;
I don't think this actually saved anything, so I switched to g_instance since I
was in the file.

https://codereview.chromium.org/2445843002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/options/network_config_view.cc (right):

https://codereview.chromium.org/2445843002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/options/network_config_view.cc:176: NetworkConfigView*
NetworkConfigView::CreateForType(const std::string& type) {
I introduced a Create method instead of ShowForTypeImpl() because |parent| can
be null in ShowForType(), so ShowForTypeImpl() would not be able to test if
(parent) {} else {} to decide whether to place in a container. I converted the
other Show code path for consistency.

[stevenjb, 2016-10-24 20:20:51]

lgtm

https://codereview.chromium.org/2445843002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/options/network_config_view.cc (left):

https://codereview.chromium.org/2445843002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/options/network_config_view.cc:66: static
NetworkConfigView* active_dialog = nullptr;
On 2016/10/24 20:14:37, James Cook wrote:
> I don't think this actually saved anything, so I switched to g_instance since
I
> was in the file.

It should be valid, but g_instace is simpler.

[James Cook, 2016-10-24 20:22:23]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-10-24 20:22:28]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:22:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 21:43:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 21:46:04]

Description was changed from

==========
chromeos: Convert "show other network" dialog to work with mash

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

Create a new NetworkConfigView::ShowForType to allow passing a container id.

Also clean up some unnecessary code around static initializers.

BUG=657021
TEST=open "join other" from system tray menu at login screen and after login
==========

to

==========
chromeos: Convert "show other network" dialog to work with mash

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

Create a new NetworkConfigView::ShowForType to allow passing a container id.

Also clean up some unnecessary code around static initializers.

BUG=657021
TEST=open "join other" from system tray menu at login screen and after login

Committed: https://crrev.com/4f08d17c7ae7f28f341428276acab0f1aa3a0078
Cr-Commit-Position: refs/heads/master@{#427160}
==========

[commit-bot: I haz the power, 2016-10-24 21:46:05]

Patchset 2 (id:??) landed as
https://crrev.com/4f08d17c7ae7f28f341428276acab0f1aa3a0078
Cr-Commit-Position: refs/heads/master@{#427160}