Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2445823002: Remove CSP referrer directive (Closed)

Created:
4 years, 1 month ago by estark
Modified:
4 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CSP referrer directive Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JqUlPA-HFfU BUG=658761 Committed: https://crrev.com/0a9c07c90d40fb1f3c76e93451948343cc306911 Cr-Commit-Position: refs/heads/master@{#427454}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix up layout tests #

Patch Set 4 : more test fixing #

Patch Set 5 : remove unused test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -796 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/referrer/no-referrer-document.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/referrer/origin-only-document.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/referrer/origin-when-cross-origin-document.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/referrer/resources/empty-referrer-origin.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/referrer/resources/origin-when-cross-origin-dedicated-worker-js.php View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-http-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-https-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-http-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-https-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-http-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-https-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-http-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-https-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-http-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-https-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-http-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-https-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-http.html View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-http-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-https-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-http-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-https-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-http-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-https-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-http-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-https-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-http-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-https-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-http.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-http-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-https.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-https-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/referrer-from-document-on-preload.php View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/referrer-from-document-on-preload-expected.html View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/resources/referrer-test.js View 1 2 3 4 1 chunk +0 lines, -62 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/resources/worker.php View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/referrer-policy-worker-no-referrer.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/referrer-from-document-on-preload.php View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/referrer-from-document-on-preload-expected.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/referrer-policy-header-then-csp.php View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/referrer-policy-header-then-meta.php View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h View 1 4 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 3 chunks +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 1 5 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 7 chunks +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 28 (23 generated)
estark
mkwst, PTAL?
4 years, 1 month ago (2016-10-25 18:10:02 UTC) #19
Mike West
LGTM! I skimmed through the CSP bits, and I think you got everything. Looks like ...
4 years, 1 month ago (2016-10-25 19:34:09 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445823002/80001
4 years, 1 month ago (2016-10-25 19:49:32 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-25 20:29:58 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 20:31:10 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0a9c07c90d40fb1f3c76e93451948343cc306911
Cr-Commit-Position: refs/heads/master@{#427454}

Powered by Google App Engine
This is Rietveld 408576698