Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2445803002: [TTS] Promote clicks on AMP carousel to a separate Tab. (Closed)

Created:
4 years, 1 month ago by Donn Denman
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[TTS] Promote clicks on AMP carousel to a separate Tab. An AMP carousel is part of the SRP (Search Result Page) and clicking on one just does sub-frame loading. Almost everything works fine except for issue 653760 which causes the subframe to scroll up but not down. This change simply promotes clicks on the AMP carousel into a separate Tab. BUG=645325 Review-Url: https://chromiumcodereview.appspot.com/2429913002 Cr-Commit-Position: refs/heads/master@{#426607} (cherry picked from commit ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d) Committed: https://chromium.googlesource.com/chromium/src/+/979bd779542cfda1a5474fb0ad24321ff4487784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java View 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Donn Denman
4 years, 1 month ago (2016-10-24 18:43:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
979bd779542cfda1a5474fb0ad24321ff4487784.

Powered by Google App Engine
This is Rietveld 408576698