Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: base/threading/sequenced_worker_pool_unittest.cc

Issue 2445763002: Disallow posting tasks to SequencedWorkerPools by default. (Closed)
Patch Set: self-review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/sequenced_worker_pool.cc ('k') | chrome/service/service_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/sequenced_worker_pool_unittest.cc
diff --git a/base/threading/sequenced_worker_pool_unittest.cc b/base/threading/sequenced_worker_pool_unittest.cc
index d2007f8be52241628321b5d55766ce308f2a80ab..39b424cdfc1402ed3c23624b8afd7c7e36c42cd4 100644
--- a/base/threading/sequenced_worker_pool_unittest.cc
+++ b/base/threading/sequenced_worker_pool_unittest.cc
@@ -254,8 +254,12 @@ class SequencedWorkerPoolTest
TaskScheduler::CreateAndSetDefaultTaskScheduler(
std::move(worker_pool_params),
base::Bind([](const TaskTraits&) -> size_t { return 0U; }));
- SequencedWorkerPool::ResetRedirectToTaskSchedulerForProcessForTesting();
- SequencedWorkerPool::RedirectToTaskSchedulerForProcess();
+
+ // Unit tests run in an environment where SequencedWorkerPool is enabled
+ // without redirection to TaskScheduler. For the current unit test,
+ // disable it and re-enable it with redirection to TaskScheduler.
+ SequencedWorkerPool::DisableForProcessForTesting();
+ SequencedWorkerPool::EnableWithRedirectionToTaskSchedulerForProcess();
}
}
@@ -267,7 +271,12 @@ class SequencedWorkerPoolTest
DeletePool();
if (RedirectedToTaskScheduler()) {
- SequencedWorkerPool::ResetRedirectToTaskSchedulerForProcessForTesting();
+ // Reset SequencedWorkerPool to its original state (i.e. enabled without
+ // redirection to TaskScheduler).
+ SequencedWorkerPool::DisableForProcessForTesting();
+ SequencedWorkerPool::EnableForProcess();
+
+ // Delete the registered TaskScheduler.
DeleteTaskScheduler();
}
}
« no previous file with comments | « base/threading/sequenced_worker_pool.cc ('k') | chrome/service/service_process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698