Fix root dictionary leak in cpdf_document_unittest

Fix root dictionary leak in cpdf_document_unittest

The CPDF_Document does not own its root dictionary, so add ownership in
CPDF_TestDocumentForPages, using ReleaseDeleter because the dictionary
cannot be deleted.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/b674ebe6dd13288160ad8e324d719a124caf5a83

[npm, 2016-10-24 15:10:06]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 15:10:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-10-24 15:15:08]

Description was changed from

==========
Fix root dictionary leak in cpdf_document_unittest

The CPDF_Document does not own its root dictionary, so add ownership in
CPDF_TestDocumentForPages, using ReleaseDeleter because the dictionary
cannot be deleted.
==========

to

==========
Fix root dictionary leak in cpdf_document_unittest

The CPDF_Document does not own its root dictionary, so add ownership in
CPDF_TestDocumentForPages, using ReleaseDeleter because the dictionary
cannot be deleted.
==========

[npm, 2016-10-24 15:15:08]

npm@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[npm, 2016-10-24 15:15:24]

PTAL

[commit-bot: I haz the power, 2016-10-24 15:21:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 15:21:24]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-24 16:09:52]

lgtm

https://codereview.chromium.org/2445753002/diff/1/core/fpdfapi/parser/cpdf_do...
File core/fpdfapi/parser/cpdf_document_unittest.cpp (right):

https://codereview.chromium.org/2445753002/diff/1/core/fpdfapi/parser/cpdf_do...
core/fpdfapi/parser/cpdf_document_unittest.cpp:79:
std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> rootDict;
nit: how about root_dict_ to go with the chromium naming conventions?  Or
m_pOwnedRootDict to go with the PDFium conventions (since there's already a
m_pRootDict in CPDF_Document)

[npm, 2016-10-24 16:17:34]

https://codereview.chromium.org/2445753002/diff/1/core/fpdfapi/parser/cpdf_do...
File core/fpdfapi/parser/cpdf_document_unittest.cpp (right):

https://codereview.chromium.org/2445753002/diff/1/core/fpdfapi/parser/cpdf_do...
core/fpdfapi/parser/cpdf_document_unittest.cpp:79:
std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> rootDict;
On 2016/10/24 16:09:52, Tom Sepez wrote:
> nit: how about root_dict_ to go with the chromium naming conventions?  Or
> m_pOwnedRootDict to go with the PDFium conventions (since there's already a
> m_pRootDict in CPDF_Document)

Done.

[npm, 2016-10-24 16:17:53]

The CQ bit was checked by npm@chromium.org

[npm, 2016-10-24 16:17:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2445753002/#ps20001
(title: "Use name convention")

[commit-bot: I haz the power, 2016-10-24 16:18:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-10-24 17:12:36]

Description was changed from

==========
Fix root dictionary leak in cpdf_document_unittest

The CPDF_Document does not own its root dictionary, so add ownership in
CPDF_TestDocumentForPages, using ReleaseDeleter because the dictionary
cannot be deleted.
==========

to

==========
Fix root dictionary leak in cpdf_document_unittest

The CPDF_Document does not own its root dictionary, so add ownership in
CPDF_TestDocumentForPages, using ReleaseDeleter because the dictionary
cannot be deleted.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/b674ebe6dd13288160ad8e324d719a124caf...
==========

[npm, 2016-10-24 17:12:37]

Committed patchset #2 (id:20001) manually as
b674ebe6dd13288160ad8e324d719a124caf5a83 (tree was closed).