Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Side by Side Diff: media/midi/midi_manager_android.cc

Issue 2445723002: Web MIDI: convert Android native API switch to a field trial (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | media/midi/midi_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/midi/midi_manager_android.h" 5 #include "media/midi/midi_manager_android.h"
6 6
7 #include "base/android/build_info.h" 7 #include "base/android/build_info.h"
8 #include "base/android/context_utils.h" 8 #include "base/android/context_utils.h"
9 #include "base/command_line.h" 9 #include "base/feature_list.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "jni/MidiManagerAndroid_jni.h" 12 #include "jni/MidiManagerAndroid_jni.h"
13 #include "media/midi/midi_device_android.h" 13 #include "media/midi/midi_device_android.h"
14 #include "media/midi/midi_manager_usb.h" 14 #include "media/midi/midi_manager_usb.h"
15 #include "media/midi/midi_output_port_android.h" 15 #include "media/midi/midi_output_port_android.h"
16 #include "media/midi/midi_switches.h" 16 #include "media/midi/midi_switches.h"
17 #include "media/midi/usb_midi_device_factory_android.h" 17 #include "media/midi/usb_midi_device_factory_android.h"
18 18
19 using base::android::JavaParamRef; 19 using base::android::JavaParamRef;
20 using midi::mojom::PortState; 20 using midi::mojom::PortState;
21 using midi::mojom::Result; 21 using midi::mojom::Result;
22 22
23 namespace midi { 23 namespace midi {
24 24
25 MidiManager* MidiManager::Create() { 25 MidiManager* MidiManager::Create() {
26 auto sdk_version = base::android::BuildInfo::GetInstance()->sdk_int(); 26 auto sdk_version = base::android::BuildInfo::GetInstance()->sdk_int();
27 if (sdk_version <= base::android::SDK_VERSION_LOLLIPOP_MR1 || 27 if (sdk_version <= base::android::SDK_VERSION_LOLLIPOP_MR1 ||
28 !base::CommandLine::ForCurrentProcess()->HasSwitch( 28 !base::FeatureList::IsEnabled(features::kMidiManagerAndroid)) {
29 switches::kUseAndroidMidiApi)) {
30 return new MidiManagerUsb(std::unique_ptr<UsbMidiDevice::Factory>( 29 return new MidiManagerUsb(std::unique_ptr<UsbMidiDevice::Factory>(
31 new UsbMidiDeviceFactoryAndroid)); 30 new UsbMidiDeviceFactoryAndroid));
32 } 31 }
33 32
34 return new MidiManagerAndroid(); 33 return new MidiManagerAndroid();
35 } 34 }
36 35
37 MidiManagerAndroid::MidiManagerAndroid() {} 36 MidiManagerAndroid::MidiManagerAndroid() {}
38 37
39 MidiManagerAndroid::~MidiManagerAndroid() { 38 MidiManagerAndroid::~MidiManagerAndroid() {
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 device->GetDeviceVersion(), PortState::CONNECTED)); 180 device->GetDeviceVersion(), PortState::CONNECTED));
182 } 181 }
183 devices_.push_back(device.release()); 182 devices_.push_back(device.release());
184 } 183 }
185 184
186 bool MidiManagerAndroid::Register(JNIEnv* env) { 185 bool MidiManagerAndroid::Register(JNIEnv* env) {
187 return RegisterNativesImpl(env); 186 return RegisterNativesImpl(env);
188 } 187 }
189 188
190 } // namespace midi 189 } // namespace midi
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | media/midi/midi_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698