Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 2445723002: Web MIDI: convert Android native API switch to a field trial (Closed)

Created:
4 years, 1 month ago by Takashi Toyoshima
Modified:
4 years, 1 month ago
Reviewers:
Ilya Sherman, yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: convert Android native API switch to a field trial To ship new MIDI backend for Android in a safe way, let me change a existing flag to a feature list flag. BUG=650913 Committed: https://crrev.com/afd7f33c654069effe366bf8513f133b32bf2c53 Cr-Commit-Position: refs/heads/master@{#430252}

Patch Set 1 #

Patch Set 2 : android only #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/midi/midi_switches.h View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M media/midi/midi_switches.cc View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (19 generated)
Takashi Toyoshima
ptal
4 years, 1 month ago (2016-10-26 22:35:32 UTC) #12
Ilya Sherman
histograms.xml lgtm
4 years, 1 month ago (2016-10-26 22:41:44 UTC) #13
yhirano
lgtm
4 years, 1 month ago (2016-10-31 10:32:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445723002/20001
4 years, 1 month ago (2016-11-07 06:22:38 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/329974)
4 years, 1 month ago (2016-11-07 06:24:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445723002/40001
4 years, 1 month ago (2016-11-07 10:19:29 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-07 11:46:12 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 11:48:45 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/afd7f33c654069effe366bf8513f133b32bf2c53
Cr-Commit-Position: refs/heads/master@{#430252}

Powered by Google App Engine
This is Rietveld 408576698