MD Settings: Don't auto-close navigable dialogs on popstate.

MD Settings: Don't auto-close navigable dialogs on popstate.

Previously, we made all cr-dialogs close on popstate. This is good,
except for navigable dialogs.

For navigable dialogs: It should open if the new route is the dialog's
route, and close otherwise. All the navigable dialogs already have code
that implements this behavior, but it conflicts with the popstate
event handler on cr-dialog.

This CL adds a parameter that disables this behavior for navigable
dialogs.

BUG=656918
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d263cf266480fb3472db7b56d54291466226c592
Cr-Commit-Position: refs/heads/master@{#427249}

[tommycli, 2016-10-24 22:02:50]

Description was changed from

==========
MD Settings: Don't auto-close navigable dialogs on popstate.

Previously, we made all cr-dialogs close on popstate. This is good,
except for navigable dialogs.

For navigable dialogs: It should open if the new route is the dialog's
route, and close otherwise. All the navigable dialogs already have code
that implements this behavior, but it conflicts with the popstate
event handler on cr-dialog.

This CL adds a parameter that disables this behavior for navigable
dialogs.

BUG=656918
==========

to

==========
MD Settings: Don't auto-close navigable dialogs on popstate.

Previously, we made all cr-dialogs close on popstate. This is good,
except for navigable dialogs.

For navigable dialogs: It should open if the new route is the dialog's
route, and close otherwise. All the navigable dialogs already have code
that implements this behavior, but it conflicts with the popstate
event handler on cr-dialog.

This CL adds a parameter that disables this behavior for navigable
dialogs.

BUG=656918
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-10-24 22:02:57]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 22:03:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-10-24 22:12:55]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 22:13:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:23:39]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tommycli, 2016-10-24 22:26:06]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 22:27:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-10-24 22:50:49]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-10-24 22:50:49]

dbeam: PTAL, thanks!

[commit-bot: I haz the power, 2016-10-25 00:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:34:14]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Dan Beam, 2016-10-25 01:24:08]

lgtm

the computer always wins

https://codereview.chromium.org/2445713004/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js (right):

https://codereview.chromium.org/2445713004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js:23:
disableAutocloseOnPopstate: {
nit: ignorePopstate

[tommycli, 2016-10-25 01:29:33]

dbeam: thanks!

https://codereview.chromium.org/2445713004/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js (right):

https://codereview.chromium.org/2445713004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js:23:
disableAutocloseOnPopstate: {
On 2016/10/25 01:24:08, Dan Beam wrote:
> nit: ignorePopstate

Done.

[tommycli, 2016-10-25 01:29:41]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-10-25 01:29:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2445713004/#ps40001
(title: "rename attribute")

[commit-bot: I haz the power, 2016-10-25 01:30:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 02:41:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-25 02:44:51]

Description was changed from

==========
MD Settings: Don't auto-close navigable dialogs on popstate.

Previously, we made all cr-dialogs close on popstate. This is good,
except for navigable dialogs.

For navigable dialogs: It should open if the new route is the dialog's
route, and close otherwise. All the navigable dialogs already have code
that implements this behavior, but it conflicts with the popstate
event handler on cr-dialog.

This CL adds a parameter that disables this behavior for navigable
dialogs.

BUG=656918
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Don't auto-close navigable dialogs on popstate.

Previously, we made all cr-dialogs close on popstate. This is good,
except for navigable dialogs.

For navigable dialogs: It should open if the new route is the dialog's
route, and close otherwise. All the navigable dialogs already have code
that implements this behavior, but it conflicts with the popstate
event handler on cr-dialog.

This CL adds a parameter that disables this behavior for navigable
dialogs.

BUG=656918
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d263cf266480fb3472db7b56d54291466226c592
Cr-Commit-Position: refs/heads/master@{#427249}
==========

[commit-bot: I haz the power, 2016-10-25 02:44:52]

Patchset 3 (id:??) landed as
https://crrev.com/d263cf266480fb3472db7b56d54291466226c592
Cr-Commit-Position: refs/heads/master@{#427249}