bluetooth: Require frame to be connected for writValue to succeed.

third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-before.js

 'use strict';

[scheib, 2016/10/24 23:58:14]

First time seeing generated files. What is this 'CALLS' thing? Takes a bit in
code search to find the info in generate.py. Where did I look first? Top of file
-- a good place to indicate something as it's easy to find in code reviews.
Also, script-tests/README. Also, at least to me it's odd to have generate.py not
be in script-tests dir.

When reading generate.py: 

PREVIOUS_CALL, FUNCTION_NAME, don't appear in the examples in file. I suppose
OK. CALL_PREVIOUS_FUNCTION and PREVIOUS_FUNCTION_NAME, may have been more clear?

I don't know what '-with-uuid' means

[ortuno, 2016/10/25 01:56:06]

I followed the same pattern as fetch. I can change if you feel strongly about
it, though I think it would be weird for a script to touch directories in its
parent's parent.

https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/test...
Hmm I might be missing something but they are included in the example:

PREVIOUS_CALL:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/bluetooth...

FUNCTION_NAME:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/bluetooth...
It's just a suffix to distinguish between getPrimaryServices() and
getPrimaryServices(uuid) tests.

I can send out a follow up patch to address these issues.

 promise_test(() => {
   let val = new Uint8Array([1]);
   return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')
     .then(() => requestDeviceWithKeyDown({
       filters: [{services: ['health_thermometer']}],
       optionalServices: [request_disconnection_service_uuid]
     }))
     .then(device => device.gatt.connect())
     .then(gattServer => {
       let measurement_interval;
       return gattServer.getPrimaryService('health_thermometer')
         .then(ht=> ht.getCharacteristic('measurement_interval'))
         .then(mi => measurement_interval = mi)
         .then(() => get_request_disconnection(gattServer))
         .then(requestDisconnection => requestDisconnection())
         .then(() => assert_promise_rejects_with_message(
-          measurement_interval.CALLS([readValue()]),
+          measurement_interval.CALLS([readValue()| writeValue(val)]),
           new DOMException(
             'GATT Server is disconnected. Cannot perform GATT operations.',
             'NetworkError')));
     });
 }, 'Device disconnects before FUNCTION_NAME. Reject with NetworkError.');