Issue 24456003: CC: Remove special case low-res scale (for Nexus tablets).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24456003: CC: Remove special case low-res scale (for Nexus tablets). (Closed)

Created:
7 years, 2 months ago by epenner

Modified:
7 years, 2 months ago

Reviewers:
piman, enne (OOO)

Base URL:
https://chromium.googlesource.com/chromium/src.git@CC_add_back_UpdateDrawProps

Visibility:
Public.

More Reviews

Description

CC: Remove special case low-res scale (for Nexus tablets). This just makes low-res scale 0.25 for all devices.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Unused variables. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -13 lines)			Patch
	M	cc/trees/layer_tree_settings.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/gpu/gpu_data_manager_impl_private.cc	View	1 2	2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epenner

Ptal. Nat, as I recall you were on board with using the same low res ...

7 years, 2 months ago (2013-09-26 00:05:24 UTC) #1

enne (OOO)

7 years, 2 months ago (2013-09-26 17:26:17 UTC) #3

As I said in https://codereview.chromium.org/22144008/, I still continue to feel
like the performance/memory issues of different low res scales haven't really
been evaluated very well or really at all.  That said, it's just changing from
one unmeasured number to another, but one that is better from a UX perspective,
so I won't say no to this simplification.

lgtm, but can you also make the test change that vmpstr makes in that nearly
equivalent code review and set the same bug number, or ajust get vmpstr to land
that one first?

Expand Messages | Collapse Messages