build/android/buildbot/bb_device_steps.py - Issue 24456002: [Android] Fork a detached child process from adb_logcat_monitor.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 24456002: [Android] Fork a detached child process from adb_logcat_monitor.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/buildbot/bb_device_steps.py

diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py

index 64f9e09218144fbd8647ede7574d920fb09b7498..92e469eef3263dca12d20e1c74f124ca5c087b90 100755

--- a/build/android/buildbot/bb_device_steps.py

+++ b/build/android/buildbot/bb_device_steps.py

@@ -285,7 +285,7 @@ def EscapeBuilderName(builder_name):

def SpawnLogcatMonitor():

shutil.rmtree(LOGCAT_DIR, ignore_errors=True)

- bb_utils.SpawnCmd([

navabi 2013/09/24 23:36:16 Why can't we spawn this command via SpawnCmd from

Siva Chandra 2013/09/24 23:47:05 Updated the CL description.

+ bb_utils.RunCmd([

os.path.join(CHROME_SRC_DIR, 'build', 'android', 'adb_logcat_monitor.py'),

LOGCAT_DIR])