Relocate display_manager from ash to ui

ui/display/manager/display_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef ASH_DISPLAY_DISPLAY_MANAGER_H_
-#define ASH_DISPLAY_DISPLAY_MANAGER_H_
+#ifndef UI_DISPLAY_MANAGER_DISPLAY_MANAGER_H_
+#define UI_DISPLAY_MANAGER_DISPLAY_MANAGER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 #include <vector>
 
-#include "ash/ash_export.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "ui/display/display.h"
+#include "ui/display/display_export.h"
 #include "ui/display/display_observer.h"
 #include "ui/display/manager/display_layout.h"
 #include "ui/display/manager/managed_display_info.h"
 
 #if defined(OS_CHROMEOS)
 #include "ui/display/chromeos/display_configurator.h"
 #endif
 
-namespace display {
-class DisplayLayoutStore;
-class DisplayObserver;
-class Screen;
-}
-
 namespace gfx {
 class Insets;
 class Rect;
 }
 
-namespace ash {
-using DisplayInfoList = std::vector<display::ManagedDisplayInfo>;
+namespace display {
+using DisplayInfoList = std::vector<ManagedDisplayInfo>;
+
+class DisplayLayoutStore;
+class DisplayObserver;
+class Screen;
 
 namespace test {
 class DisplayManagerTestApi;
 }
 
 // DisplayManager maintains the current display configurations,
 // and notifies observers when configuration changes.
 //
 // TODO(oshima): Make this non internal.

[kylechar, 2016/10/24 14:55:15]

TODO is fulfilled.

[oshima, 2016/10/24 19:29:16]

yes :)

[rjkroege, 2016/10/25 23:30:26]

Done! :-)

-class ASH_EXPORT DisplayManager
+class DISPLAY_EXPORT DisplayManager
 #if defined(OS_CHROMEOS)
     : public ui::DisplayConfigurator::SoftwareMirroringController
 #endif
 {
  public:
-  class ASH_EXPORT Delegate {
+  class DISPLAY_EXPORT Delegate {
    public:
     virtual ~Delegate() {}
 
     // Create or updates the mirroring window with |display_info_list|.
     virtual void CreateOrUpdateMirroringDisplay(
         const DisplayInfoList& display_info_list) = 0;
 
     // Closes the mirror window if not necessary.
     virtual void CloseMirroringDisplayIfNotNecessary() = 0;
 
     // Called before and after the display configuration changes.
     // When |clear_focus| is true, the implementation should
     // deactivate the active window and set the focus window to NULL.
     virtual void PreDisplayConfigurationChange(bool clear_focus) = 0;
-    virtual void PostDisplayConfigurationChange() = 0;
+    virtual void PostDisplayConfigurationChange(bool must_clear_window) = 0;
 
 #if defined(OS_CHROMEOS)
     // Get the ui::DisplayConfigurator.
     virtual ui::DisplayConfigurator* display_configurator() = 0;
 #endif
 
     virtual std::string GetInternalDisplayNameString() = 0;
     virtual std::string GetUnknownDisplayNameString() = 0;
   };
 
   // How the second display will be used.
   // 1) EXTENDED mode extends the desktop to the second dislpay.
   // 2) MIRRORING mode copies the content of the primary display to
   //    the 2nd display. (Software Mirroring).
   // 3) UNIFIED mode creates single desktop across multiple displays.
   enum MultiDisplayMode {
     EXTENDED = 0,
     MIRRORING,
     UNIFIED,
   };
 
   // The display ID for a virtual display assigned to a unified desktop.
   static int64_t kUnifiedDisplayId;
 
-  explicit DisplayManager(std::unique_ptr<display::Screen> screen);
+  explicit DisplayManager(std::unique_ptr<Screen> screen);
 #if defined(OS_CHROMEOS)
   ~DisplayManager() override;
 #else
   virtual ~DisplayManager();
 #endif
 
-  display::DisplayLayoutStore* layout_store() { return layout_store_.get(); }
+  DisplayLayoutStore* layout_store() { return layout_store_.get(); }
 
   void set_delegate(Delegate* delegate) { delegate_ = delegate; }
 
   // When set to true, the DisplayManager calls OnDisplayMetricsChanged
   // even if the display's bounds didn't change. Used to swap primary
   // display.
   void set_force_bounds_changed(bool force_bounds_changed) {
     force_bounds_changed_ = force_bounds_changed;
   }
 
@@ skipping 301 matching lines @@
   void RunPendingTasksForTest();
 
   // Applies the |layout| and updates the bounds of displays in |display_list|.
   // |updated_ids| contains the ids for displays whose bounds have changed.
   void ApplyDisplayLayout(const display::DisplayLayout& layout,
                           display::Displays* display_list,
                           std::vector<int64_t>* updated_ids);
 
   Delegate* delegate_;  // not owned.
 
-  std::unique_ptr<display::Screen> screen_;
+  std::unique_ptr<Screen> screen_;
 
-  std::unique_ptr<display::DisplayLayoutStore> layout_store_;
+  std::unique_ptr<DisplayLayoutStore> layout_store_;
 
   int64_t first_display_id_;
 
   // List of current active displays.
-  display::Displays active_display_list_;
+  Displays active_display_list_;
   // This list does not include the displays that will be removed if
   // |UpdateDisplaysWith| is under execution.
   // See https://crbug.com/632755
-  display::Displays active_only_display_list_;
+  Displays active_only_display_list_;
 
   // True if active_display_list is being modified and has displays that are not
   // presently active.
   // See https://crbug.com/632755
   bool is_updating_display_list_;
 
   int num_connected_displays_;
 
   bool force_bounds_changed_;
 
   // The mapping from the display ID to its internal data.
-  std::map<int64_t, display::ManagedDisplayInfo> display_info_;
+  std::map<int64_t, ManagedDisplayInfo> display_info_;
 
   // Selected display modes for displays. Key is the displays' ID.
-  std::map<int64_t, scoped_refptr<display::ManagedDisplayMode>> display_modes_;
+  std::map<int64_t, scoped_refptr<ManagedDisplayMode>> display_modes_;
 
   // When set to true, the host window's resize event updates
   // the display's size. This is set to true when running on
   // desktop environment (for debugging) so that resizing the host
   // window will update the display properly. This is set to false
   // on device as well as during the unit tests.
   bool change_display_upon_host_resize_;
 
   MultiDisplayMode multi_display_mode_;
   MultiDisplayMode current_default_multi_display_mode_;
 
   int64_t mirroring_display_id_;
-  display::Displays software_mirroring_display_list_;
+  Displays software_mirroring_display_list_;
 
   // User preference for rotation lock of the internal display.
   bool registered_internal_display_rotation_lock_;
 
   // User preference for the rotation of the internal display.
-  display::Display::Rotation registered_internal_display_rotation_;
+  Display::Rotation registered_internal_display_rotation_;
 
   bool unified_desktop_enabled_;
 
-  base::ObserverList<display::DisplayObserver> observers_;
+  base::ObserverList<DisplayObserver> observers_;
 
   base::WeakPtrFactory<DisplayManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DisplayManager);
 };
 
-}  // namespace ash
+}  // namespace display
 
-#endif  // ASH_DISPLAY_DISPLAY_MANAGER_H_
+#endif  // UI_DISPLAY_MANAGER_DISPLAY_MANAGER_H_