Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2445553002: cc: Make OutputSurface entirely live on one thread in tests. (Closed)

Created:
4 years, 2 months ago by danakj
Modified:
4 years, 1 month ago
Reviewers:
enne (OOO), piman
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make OutputSurface entirely live on one thread in tests. OutputSurface is single-threaded but it ends up being created on the main thread and used on compositor thread in cc unit tests and layout tests, where it is directly attached to the renderer compositor. Rework these tests so OutputSurface is only on a single thread to reduce complexity of the class (will allow removal of BindToClient entirely). R=enne@chromium.org BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/7bbd659851f812efc44d37e36315e9524cdae44b Cr-Commit-Position: refs/heads/master@{#427495}

Patch Set 1 #

Patch Set 2 : osonthread: fixcontextdeleteintest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -109 lines) Patch
M cc/layers/texture_layer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_test.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M cc/test/test_compositor_frame_sink.h View 5 chunks +11 lines, -3 lines 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 5 chunks +39 lines, -34 lines 0 comments Download
M cc/test/test_hooks.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +29 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 10 chunks +12 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 1 7 chunks +11 lines, -8 lines 0 comments Download
M content/test/layouttest_support.cc View 5 chunks +46 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
danakj
4 years, 2 months ago (2016-10-22 00:58:28 UTC) #2
enne (OOO)
lgtm
4 years, 2 months ago (2016-10-22 01:11:00 UTC) #3
danakj
+piman for content/
4 years, 1 month ago (2016-10-24 18:30:43 UTC) #5
piman
lgtm
4 years, 1 month ago (2016-10-24 22:49:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445553002/1
4 years, 1 month ago (2016-10-25 00:51:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/54630)
4 years, 1 month ago (2016-10-25 01:25:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445553002/20001
4 years, 1 month ago (2016-10-25 20:46:21 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 21:54:02 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:57:25 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7bbd659851f812efc44d37e36315e9524cdae44b
Cr-Commit-Position: refs/heads/master@{#427495}

Powered by Google App Engine
This is Rietveld 408576698