Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2445543002: Make git cl patch work with binary files. (Closed)

Created:
4 years, 2 months ago by skobes
Modified:
4 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Dirk Pranke
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -72 lines) Patch
M git_cl.py View 1 6 chunks +11 lines, -57 lines 0 comments Download
M tests/git_cl_test.py View 7 chunks +24 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
skobes
4 years, 2 months ago (2016-10-22 01:33:21 UTC) #8
tandrii(chromium)
LGTM % nit, assuming you've tested it and it worked. And thanks! https://codereview.chromium.org/2445543002/diff/20001/git_cl.py File git_cl.py ...
4 years, 1 month ago (2016-10-23 23:03:43 UTC) #9
skobes
https://codereview.chromium.org/2445543002/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2445543002/diff/20001/git_cl.py#newcode1982 git_cl.py:1982: return 1; On 2016/10/23 23:03:43, tandrii(chromium) wrote: > nit: ...
4 years, 1 month ago (2016-10-24 15:41:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445543002/40001
4 years, 1 month ago (2016-10-24 15:41:56 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 15:45:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/6468b9068b721b...

Powered by Google App Engine
This is Rietveld 408576698