Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: content/renderer/media/webmediaplayer_ms.cc

Issue 2445533002: Don't suspend the pipeline before HaveFutureData while decoding progressing (Closed)
Patch Set: wmpi tests and delegate tests and delegate test refactor Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webmediaplayer_ms.cc
diff --git a/content/renderer/media/webmediaplayer_ms.cc b/content/renderer/media/webmediaplayer_ms.cc
index c8b28aaff1e5f06549949902a3d67ae2d1a340fc..9ed9db8de9431eb762414aeb56a269c7e1e8fcad 100644
--- a/content/renderer/media/webmediaplayer_ms.cc
+++ b/content/renderer/media/webmediaplayer_ms.cc
@@ -421,11 +421,12 @@ void WebMediaPlayerMS::OnShown() {
#endif // defined(OS_ANDROID)
}
-void WebMediaPlayerMS::OnSuspendRequested(bool must_suspend) {
+bool WebMediaPlayerMS::OnSuspendRequested(bool must_suspend) {
#if defined(OS_ANDROID)
if (!must_suspend)
- return;
+ return false;
+ accepted = true;
if (!paused_) {
pause();
should_play_upon_shown_ = true;
@@ -436,6 +437,7 @@ void WebMediaPlayerMS::OnSuspendRequested(bool must_suspend) {
render_frame_suspended_ = true;
#endif
+ return true;
}
void WebMediaPlayerMS::OnPlay() {

Powered by Google App Engine
This is Rietveld 408576698